Bug 15624 - DH reconnect error handling can lead to stale sharemode entries
Summary: DH reconnect error handling can lead to stale sharemode entries
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.19.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-09 15:12 UTC by Ralph Böhme
Modified: 2024-09-19 19:37 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2024-04-09 15:12:14 UTC 
Currently in some error code paths in the DH reconnect code we leave stale sharemode entries around that can lead to all sorts of havoc.
Comment 1 Ralph Böhme 2024-04-09 15:14:59 UTC 
Note, one way I've seen this happen is with a custom private VFS module stack that causes incorrect stat info in the cookie compared to the result from SMB_VFS_FSTAT() in the reconnect function.

Have patch, need bugnumber.
Comment 2 Samba QA Contact 2024-09-19 19:37:04 UTC 
This bug was referenced in samba master:

d76edcd48437715c7541b5b1e6a56245c25f460b
5c57e840527432c4b1a7ec94894939022a9e9622
7add7dbf1aee13b4d9ab70d1a5312c8ff30d9e00
b45e78871aadca6ae33475bee890736838f44219
d8613d7ee23c4e990285a387eb9ac2eeefff9749
679e12aee2f0c283a6f9b9c6008c549a6ca9633e
90d776cb18395ed804f0ab4fd13ef571fc0ad827
692ed832dfff61ad1c9b646b5c8d6f85f25efb99
ef4ef04e7f83b1029446ff8b5fc5fdf4ab33edbd
14875448ca06a3a28800343a3a326f1a66bccec0
a91457f97c98fcec1ed062514c364271af1df669
2ff3b9bc0d254a63a913ff9084de3d794fee27d0