A user reported that samba-gpupdate segfaults with: Program received signal SIGSEGV, Segmentation fault. ndr_push_security_descriptor (ndr=ndr@entry=0x555555bf41b0, ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at librpc/gen_ndr/ndr_security.c:713 713 NDR_CHECK(ndr_push_security_descriptor_revision(ndr, NDR_SCALARS, r->revision)); Thread 1 (Thread 0x7ffff7ece740 (LWP 21460) "python3"): #0 ndr_push_security_descriptor (ndr=ndr@entry=0x555555bf41b0, ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at librpc/gen_ndr/ndr_security.c:713 _flags_save_STRUCT = 0 _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> _status = <optimized out> __FUNCTION__ = "ndr_push_security_descriptor" #1 0x00007ffff617237f in ndr_push_struct_blob (blob=blob@entry=0x7fffffffdb20, mem_ctx=0x555555aa3bd0, p=0x0, fn=0x7ffff6074ad0 <ndr_push_security_descriptor>, fn@entry=0x7ffff60706c8 <ndr_push_security_descriptor@plt>) at ../../librpc/ndr/ndr.c:1438 _status = <optimized out> ndr = 0x555555bf41b0 #2 0x00007ffff607cccf in marshall_sec_desc (mem_ctx=<optimized out>, secdesc=<optimized out>, data=data@entry=0x7fffffffdb80, len=len@entry=0x7fffffffdb78) at ../../libcli/security/secdesc.c:241 blob = {data = 0x7fffffffdb40 "`\333\377\377\377\177", length = 140737352374299} ndr_err = <optimized out> __FUNCTION__ = "marshall_sec_desc" #3 0x00007ffff29edd94 in GPO_marshall_get_sec_desc_buf (self=<optimized out>, args=<optimized out>, kwds=<optimized out>) at ../../libgpo/pygpo.c:119 gpo_ptr = <optimized out> status = <optimized out> data = 0x0 len = 0
This bug was referenced in samba master: b13d4359f2f16e391763d1dc6a5718def973fabb
Created attachment 18264 [details] patch for 4.20
Created attachment 18265 [details] patch for 4.19
Comment on attachment 18265 [details] patch for 4.19 LGTM
Jule, please add to v4.19 and v4.20, thanks!
Pushed to autobuild-v4-{20,19}-test.
This bug was referenced in samba v4-20-test: 69b69bb2085dfc842292db14eadbcba71b096d69
This bug was referenced in samba v4-19-test: a58338ec926d4979253b86fcc273be66e708adbd
Closing out bug report. Thanks!
This bug was referenced in samba v4-20-stable (Release samba-4.20.0): 69b69bb2085dfc842292db14eadbcba71b096d69
This bug was referenced in samba v4-19-stable (Release samba-4.19.6): a58338ec926d4979253b86fcc273be66e708adbd