Bug 15588 - samba-gpupdate: Correctly implement site support
Summary: samba-gpupdate: Correctly implement site support
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Python (show other bugs)
Version: 4.19.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-21 07:59 UTC by Andreas Schneider
Modified: 2024-04-08 07:34 UTC (History)
2 users (show)

See Also:

Attachments
patch for 4.19 (7.36 KB, patch)
2024-02-27 06:51 UTC, Andreas Schneider 		ab: review+
Details
patch for 4.20 (7.44 KB, patch)
2024-02-27 06:52 UTC, Andreas Schneider 		ab: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2024-02-21 07:59:53 UTC 
The site support for samba-gpupdate is not working. We need to implement the ldap call netr_DrsGetSiteName() implements.

Working on a patch.
Comment 1 Samba QA Contact 2024-02-26 08:07:04 UTC 
This bug was referenced in samba master:

e758425869729a43136ae51e6baecb2061d1525b
e4c3c61302b12419f041867b58350f11dc800318
Comment 2 Andreas Schneider 2024-02-27 06:51:38 UTC 
Created attachment 18261 [details]
patch for 4.19
Comment 3 Andreas Schneider 2024-02-27 06:52:05 UTC 
Created attachment 18262 [details]
patch for 4.20
Comment 4 Alexander Bokovoy 2024-02-27 09:15:30 UTC 
Comment on attachment 18261 [details]
patch for 4.19

LGTM
Comment 5 Alexander Bokovoy 2024-02-27 09:15:57 UTC 
Comment on attachment 18262 [details]
patch for 4.20

LGTM
Comment 6 Andreas Schneider 2024-02-27 17:32:05 UTC 
Jule, could you please apply the patches to the matching branches? Thanks!
Comment 7 Jule Anger 2024-03-01 07:41:58 UTC 
Pushed to autobuild-v4-{20,19}-test.
Comment 8 Samba QA Contact 2024-03-01 08:53:03 UTC 
This bug was referenced in samba v4-19-test:

111e85a589cbe4ff5ce2f42e8ebfb3048d30374f
8ea3973ad4025c460b5e0da8d67a3deec734e7c6
Comment 9 Samba QA Contact 2024-03-01 09:02:13 UTC 
This bug was referenced in samba v4-20-test:

e51e72dd14afa3e299a577774c430f4b4b1e2b17
03b6dae6630c6de85af1f20276df11e67d7601e2
Comment 10 Jule Anger 2024-03-01 12:31:14 UTC 
Closing out bug report.

Thanks!
Comment 11 Samba QA Contact 2024-03-11 15:02:57 UTC 
This bug was referenced in samba v4-20-stable (Release samba-4.20.0rc4):

e51e72dd14afa3e299a577774c430f4b4b1e2b17
03b6dae6630c6de85af1f20276df11e67d7601e2
Comment 12 Samba QA Contact 2024-04-08 07:34:12 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.6):

111e85a589cbe4ff5ce2f42e8ebfb3048d30374f
8ea3973ad4025c460b5e0da8d67a3deec734e7c6