15574 – Performance regression for NDR parsing of security descriptors

Bug 15574 - Performance regression for NDR parsing of security descriptors

Summary: Performance regression for NDR parsing of security descriptors

Status:	RESOLVED FIXED

Alias:	None

Product:	Samba 4.1 and newer
Classification:	Unclassified
Component:	AD: LDB/DSDB/SAMDB (show other bugs)
Version:	4.20.0rc1
Hardware:	All All

Importance:	P5 normal (vote)
Target Milestone:	---
Assignee:	Jule Anger
QA Contact:	Samba QA Contact

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-02-08 01:17 UTC by Andrew Bartlett
Modified:	2024-02-12 19:55 UTC (History)
CC List:	3 users (show)

See Also:	https://gitlab.com/samba-team/samba/-/merge_requests/3489

Attachments
patch for Samba 4.20 (39.34 KB, patch) 2024-02-08 18:18 UTC, Jennifer Sutton	dbagnall: review+	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Bartlett 2024-02-08 01:17:32 UTC

Comment 1 Samba QA Contact 2024-02-08 03:52:09 UTC

This bug was referenced in samba master:

d5371f6bcd2fe991d08fcf2006ce62e6a7449ae9
e802611743a9b899c18d6eeaa0a46323b676c296
d25fe2447b553087f6285c80907ca5d0debcd827
ceb5389260c4469a8f03ee884325ca981c18a36a
2f68545087f25e5d4c7a7742d99527c7ebbd02ab
93e6ea4cff2cb6bd084db27139addeea06945ea5
5fa663766548eac2cc5932ae03d03b79ad1751b5
9811762775b28e16035afb2c319b55c4bf3699d3
1e6a876c2cc4b3b54895dde879492e756bb9b963
ac0c8ee01ea624e9c486251da2132710c2a43ddc
dc08e7924c2e359afeb4b86f306868cad00189a0
ee1b8ae04b10306c059174a5b4b637b080fe23fd
c2673b02a7a51761e8b6631eb0c0e7062cbbed7b
4face258dee93dcd01dce71fcb7448b285ff4860
2a60ec98409b161cfeb4b51414ba61feb26c01b9
fce4d51eb492a6fc807c6849cd4bd65ca7714509
ecb5da3e49283ca3a03dea81d22db4a081e192e4
a72c198921f64f2502f543c7158762c64cb3074e
0c1f421c107be3156b3f1db75aced24a1bca3d2f

Comment 2 Jennifer Sutton 2024-02-08 18:18:03 UTC

Created attachment 18244 [details]
patch for Samba 4.20

Comment 3 Douglas Bagnall 2024-02-08 22:25:14 UTC

for 4.20. thanks.

Comment 4 Jule Anger 2024-02-12 10:06:13 UTC

Pushed to autobuild-v4-20-test.

Comment 5 Samba QA Contact 2024-02-12 11:56:11 UTC

This bug was referenced in samba v4-20-test:

daf5b5f5eb2906e793836505d4777c8340b633d1
66fa6885551e3d16692f5dab23f9c7bdf0c52e66
7f0bdf2b99e0891c2705b3472cace34b2b20f280
1287f182167253c03e84fa6a934c7df38323ddeb
14edd0fd1ef8b05e51ce8f67c1208c8160cd59f0
fb49ce4760979194bddd644bfe8f497f34e7193d
b5289d66e9ed6f95419b908f005c14c3afe42528
f8014cae2ebebd1364806e92d6a0c19ace4c7789
8787185a6caef33f3053ae29587ea88d06d30be1
c9974e622bf0a62d65376d4bae417924f7ec8e03
e4cf11b1b399daca6de070f6166e66ce85d81894
e61d447690f12a5e9be236517716d63626a859f8
5d0d17a92db235cecb5bbe4c6a0efc29a294c745
d4547daf5eed02e7820519a40cff42259fa74d43
5c0f6a207453c1ef11fc8cef42ab0a6b02abf99b
276e67fe174caab58d9a020a9357ca0d04631f13
4808478685caea32b5d5580a940b314f785000c3
0f81aec9a19fe3f0c7d1bcc26c2d354a22747903
7f338d6119acd5a3129248d4e61df626f4087560

Comment 6 Jule Anger 2024-02-12 13:06:32 UTC

Closing out bug report.

Thanks!

Comment 7 Samba QA Contact 2024-02-12 19:55:14 UTC

This bug was referenced in samba v4-20-stable (Release samba-4.20.0rc2):

daf5b5f5eb2906e793836505d4777c8340b633d1
66fa6885551e3d16692f5dab23f9c7bdf0c52e66
7f0bdf2b99e0891c2705b3472cace34b2b20f280
1287f182167253c03e84fa6a934c7df38323ddeb
14edd0fd1ef8b05e51ce8f67c1208c8160cd59f0
fb49ce4760979194bddd644bfe8f497f34e7193d
b5289d66e9ed6f95419b908f005c14c3afe42528
f8014cae2ebebd1364806e92d6a0c19ace4c7789
8787185a6caef33f3053ae29587ea88d06d30be1
c9974e622bf0a62d65376d4bae417924f7ec8e03
e4cf11b1b399daca6de070f6166e66ce85d81894
e61d447690f12a5e9be236517716d63626a859f8
5d0d17a92db235cecb5bbe4c6a0efc29a294c745
d4547daf5eed02e7820519a40cff42259fa74d43
5c0f6a207453c1ef11fc8cef42ab0a6b02abf99b
276e67fe174caab58d9a020a9357ca0d04631f13
4808478685caea32b5d5580a940b314f785000c3
0f81aec9a19fe3f0c7d1bcc26c2d354a22747903
7f338d6119acd5a3129248d4e61df626f4087560