Bug 15545 - A build with --private-libraries=ALL does not work
Summary: A build with --private-libraries=ALL does not work
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.19.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/-...
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-29 15:32 UTC by Stefan Metzmacher
Modified: 2024-01-04 13:04 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2023-12-29 15:32:42 UTC 
$ ./configure --private-libraries=ALL
$ make smbd/smbd
Waf: Leaving directory `/home/test/src/samba_opensource/samba/bin/default'
Task dependency cycle in "run_after" constraints:
{task 139845275888080: cshlib dcerpc-samba4.empty.c.12.o,ndr_winbind_c.c.229.o -> libdcerpc-samba4.so}
make: *** [Makefile:131: smbd/smbd] Error 1

The problem is that we use opt.PRIVATE_EXTENSION_DEFAULT('samba4') and
libndr as private will become libndr-samba4 and that already exists as libndr-samba4 as we don't append the extension if it's already there.
Comment 1 Samba QA Contact 2024-01-04 12:46:12 UTC 
This bug was referenced in samba master:

533e5daf772b38e21830251d779f083da7197058
a80614fe3098be42f330a73c5af28e646a86a042
3ae5afa6ad0421f479c5fe63ed692593eaed7078
f22df59b0655f9bb812c39734782b0ff3c71c954
6da49582c212aefe859c71688a2d7beb72125fa9
16d802f9c1f61cebb3699942242fbd3717f0dc4e
Comment 2 Stefan Metzmacher 2024-01-04 13:04:01 UTC 
Fixed in master for 4.20, for older releases use something like:

--private-libraries=ALL --private-library-extension=private-library