Bug 15499 - Improve logging for failover scenarios
Summary: Improve logging for failover scenarios
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.19.2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-19 11:56 UTC by Pavel Filipenský
Modified: 2023-11-27 12:12 UTC (History)
1 user (show)

See Also:

Attachments
4.19 patch (7.86 KB, patch)
2023-10-19 12:04 UTC, Pavel Filipenský 		asn: review-
Details
4.19 patch (8.07 KB, patch)
2023-10-23 07:40 UTC, Pavel Filipenský 		asn: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Filipenský 2023-10-19 11:56:11 UTC 
This is a place holder for backporting these commits from master to samba 4.19:

14600a3 2023-10-18 11:32 +0200 Pavel Filipenský   o s3:libads: Improve logging for failover scenarios
5f7a834 2023-10-18 11:32 +0200 Pavel Filipenský   o s3:libsmb: Improve logging for failover scenarios
6063f3e 2023-10-18 11:32 +0200 Pavel Filipenský   o s3:winbindd: Improve logging for failover scenarios in winbindd_pam.c
21bb84e 2023-10-18 11:32 +0200 Pavel Filipenský   o s3:winbindd: Improve logging for failover scenarios in winbindd_cm.c
Comment 1 Pavel Filipenský 2023-10-19 12:04:12 UTC 
Created attachment 18169 [details]
4.19 patch

Patch cherry picked using:
git cherry-pick -x 21bb84e^..14600a3
Comment 2 Andreas Schneider 2023-10-20 06:46:42 UTC 
The patches do not have the

BUG: ...

reference in the comments, please add :-)
Comment 3 Pavel Filipenský 2023-10-23 07:40:31 UTC 
Created attachment 18170 [details]
4.19 patch

added to commit message:

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15499
Comment 4 Andreas Schneider 2023-10-23 08:05:49 UTC 
Jule, can you please apply the patch to Samba 4.19? Thanks!
Comment 5 Jule Anger 2023-10-23 08:35:12 UTC 
Pushed to autobuild-v4-19-test.
Comment 6 Samba QA Contact 2023-10-23 09:44:04 UTC 
This bug was referenced in samba v4-19-test:

7038794ec855fd70e76d30f005722ec9c86d071b
0bb520822c9401f0638e86ec2b7a8665a8776934
8c0f12065602c3d38b49350b486a12d6e6599cbf
ba252e247c52ccc7fe54d18b8f9ce88cc53ce1c3
Comment 7 Jule Anger 2023-10-23 12:26:34 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2023-11-27 12:12:35 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.3):

7038794ec855fd70e76d30f005722ec9c86d071b
0bb520822c9401f0638e86ec2b7a8665a8776934
8c0f12065602c3d38b49350b486a12d6e6599cbf
ba252e247c52ccc7fe54d18b8f9ce88cc53ce1c3