Bug 15497 - Add make command for querying Samba version
Summary: Add make command for querying Samba version
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.11.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-16 16:51 UTC by Christof Schmitt
Modified: 2023-12-15 06:43 UTC (History)
3 users (show)

See Also:
obnox: review? (gd)
anoopcs: review-

Attachments
patch cherry-picked from master (2.21 KB, patch)
2023-10-17 11:26 UTC, Michael Adam 		gd: review+
gd: ci-passed+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christof Schmitt 2023-10-16 16:51:13 UTC 
Add a simple make command to query Samba version. This is useful
for packaging script. Not technically a defect, but since it is
an easy change, we should backport to the support Samba release.
Comment 1 Samba QA Contact 2023-10-17 04:17:04 UTC 
This bug was referenced in samba master:

e2ace2d613701f3d4a7c7c202f68d2f193c0a64a
310629508bfbedecfab9b653b7cba0282f5c0e8b
Comment 2 Michael Adam 2023-10-17 11:26:30 UTC 
Created attachment 18165 [details]
patch cherry-picked from master
Comment 3 Michael Adam 2023-10-17 11:27:31 UTC 
master MR: https://gitlab.com/samba-team/samba/-/merge_requests/3324
Comment 4 Guenther Deschner 2023-10-17 15:45:02 UTC 
Comment on attachment 18165 [details]
patch cherry-picked from master

LGTM, RB+
Comment 5 Guenther Deschner 2023-10-17 15:46:55 UTC 
Jule, please add to the next release.
Comment 6 Michael Adam 2023-10-17 16:44:39 UTC 
Comment on attachment 18165 [details]
patch cherry-picked from master

patch is for v4-18-test
Comment 7 Jule Anger 2023-10-20 09:23:34 UTC 
(In reply to Michael Adam from comment #6)
Pushed to autobuild-v4-18-test.
The fix is only for 4.18 and not for 4.19, right?
Comment 8 Michael Adam 2023-10-20 09:53:47 UTC 
(In reply to Jule Anger from comment #7)
> (In reply to Michael Adam from comment #6)
> Pushed to autobuild-v4-18-test.

Thanks Jule!
> The fix is only for 4.18 and not for 4.19, right?

Well the  patch  is intended for  4.18 now but I should check with the reporter (Christof) if we need it in  4.19 as well ...
Comment 9 Samba QA Contact 2023-10-23 09:53:03 UTC 
This bug was referenced in samba v4-18-test:

acf4286fbed5014af58a7fcf0055b1b80f00705d
8e33532980d9b4b16520a5092336bd86f882e0f5
Comment 10 Jule Anger 2023-11-20 08:57:33 UTC 
Closing out bug report. If the bug should also be applied in 4.19, please reopen.

Thanks!
Comment 11 Samba QA Contact 2023-11-29 14:39:03 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.9):

acf4286fbed5014af58a7fcf0055b1b80f00705d
8e33532980d9b4b16520a5092336bd86f882e0f5