Bug 15481 - GETREALFILENAME_CACHE can modify incoming new filename with previous cache entry value.
Summary: GETREALFILENAME_CACHE can modify incoming new filename with previous cache en...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-20 17:19 UTC by Jeremy Allison
Modified: 2023-10-16 14:20 UTC (History)
1 user (show)

See Also:

Attachments
"raw" patch (3.92 KB, patch)
2023-09-20 17:19 UTC, Jeremy Allison 		no flags Details
git-am fix for 4.19.next, 4.18.next. (4.57 KB, patch)
2023-09-21 00:45 UTC, Jeremy Allison 		vl: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2023-09-20 17:19:46 UTC 
Created attachment 18113 [details]
"raw" patch

Found by Apple at the SMB3 IOLab. Standard case insensitive but case preserving share.

1). Create a new file "file".
2). Delete the file.
3). Create a new file called "File".

File in disk created is called "file", not file.

Fixed by Volker, "raw" patch attached for reference.
Comment 2 Samba QA Contact 2023-09-20 22:43:03 UTC 
This bug was referenced in samba master:

56df75d44795582dcecb8676a0d80d6f4a46c7e9
3481bbfede5127e3664bcf464a0ae3dec9247ab7
Comment 3 Jeremy Allison 2023-09-21 00:45:56 UTC 
Created attachment 18114 [details]
git-am fix for 4.19.next, 4.18.next.

Cherry-picked from master. Applies cleanly to 4.19.next, 4.18.next.
Comment 4 Jule Anger 2023-09-22 19:33:33 UTC 
Pushed to autobuild-v4-{19,18}-test.
Comment 5 Samba QA Contact 2023-09-22 20:35:16 UTC 
This bug was referenced in samba v4-19-test:

ebc4bbbf7072307b743cb2ac53c6e86f71b834c6
79101588626972b3aaa2ffc98bbde476596691d0
Comment 6 Samba QA Contact 2023-09-22 21:08:03 UTC 
This bug was referenced in samba v4-18-test:

7de498a38d93411cb4810456b6bd42e9a5ead4ce
c4fd0850c5e855af326913147c10dea70f8e7322
Comment 7 Jule Anger 2023-09-25 08:07:57 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2023-09-27 08:16:28 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.7):

7de498a38d93411cb4810456b6bd42e9a5ead4ce
c4fd0850c5e855af326913147c10dea70f8e7322
Comment 9 Samba QA Contact 2023-10-16 14:20:16 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.2):

ebc4bbbf7072307b743cb2ac53c6e86f71b834c6
79101588626972b3aaa2ffc98bbde476596691d0