Bug 15460 - Logging to stdout/stderr with DEBUG_SYSLOG_FORMAT_ALWAYS can log to syslog
Summary: Logging to stdout/stderr with DEBUG_SYSLOG_FORMAT_ALWAYS can log to syslog
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: 4.19.0rc3
Hardware: All All
: P5 regression (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-28 00:21 UTC by Martin Schwenke
Modified: 2024-02-13 20:29 UTC (History)
1 user (show)

See Also:

Attachments
Patch for v4-19-test (2.75 KB, patch)
2023-08-28 01:54 UTC, Martin Schwenke 		abartlet: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2023-08-28 00:21:22 UTC 
Commit 83fe7a0316d3e5867a56cfdc51ec17f36ea03889 converted the stdout/stderr logging  types to DEBUG_FILE to get a header when using DEBUG_SYSLOG_FORMAT_ALWAYS.  However, this causes all configured backends to be invoked.  When syslog is one of those backends then this is almost certainly not what is intended.
Comment 2 Samba QA Contact 2023-08-28 01:22:05 UTC 
This bug was referenced in samba master:

c7672779128ff12eb7a5cb34052559e62adbd5cb
Comment 3 Martin Schwenke 2023-08-28 01:54:53 UTC 
Created attachment 18071 [details]
Patch for v4-19-test

Cherry picks cleanly, compiles.  "make test" appears to only log to expected files and not syslog. Looks good.
Comment 4 Andrew Bartlett 2023-08-28 03:11:32 UTC 
Assigning to Jule for next 4.19 release candidate
Comment 5 Jule Anger 2023-08-28 08:37:32 UTC 
Pushed to autobuild-v4-19-test.
Comment 6 Samba QA Contact 2023-08-28 09:37:03 UTC 
This bug was referenced in samba v4-19-test:

fb774d5d4257fde3a3ff8052434c79e219ecdce4
Comment 7 Jule Anger 2023-08-28 13:50:33 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2023-08-28 14:20:14 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.0rc4):

fb774d5d4257fde3a3ff8052434c79e219ecdce4