Bug 15451 - ctdb_killtcp fails to work with --enable-pcap and libpcap ≥ 1.9.1.
Summary: ctdb_killtcp fails to work with --enable-pcap and libpcap ≥ 1.9.1.
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: CTDB (show other bugs)
Version: 4.17.0
Hardware: All Linux
: P5 major (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-15 03:33 UTC by Martin Schwenke
Modified: 2023-09-27 08:15 UTC (History)
1 user (show)

See Also:

Attachments
Patch for v4-19-test (6.85 KB, patch)
2023-08-15 23:01 UTC, Martin Schwenke 		vl: review+
Details
Patch for v4-18-test (6.85 KB, patch)
2023-08-15 23:02 UTC, Martin Schwenke 		vl: review+
Details
Patch for v4-17-test (29.99 KB, patch)
2023-08-15 23:08 UTC, Martin Schwenke 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Schwenke 2023-08-15 03:33:02 UTC 
A change in behaviour in libpcap means that ctdb_killtcp no longer works when configured with --enable-pcap and compiled against libpcap ≥ 1.9.1.

See:

  https://github.com/the-tcpdump-group/libpcap/issues/860

and pcap_set_immediate_mode(3PCAP) for more details.

About to post merge request with fix.
Comment 1 Martin Schwenke 2023-08-15 05:26:33 UTC 
Merge request: https://gitlab.com/samba-team/samba/-/merge_requests/3225
Comment 2 Samba QA Contact 2023-08-15 10:54:03 UTC 
This bug was referenced in samba master:

d87041d8968e91db9d257445321b85693303f95e
ffc2ae616d8fab7528fbdfd8c6b94c5b9a0e3a7c
dc7b48c404337891b5105df4d6751cf549a533eb
Comment 3 Martin Schwenke 2023-08-15 23:01:37 UTC 
Created attachment 18059 [details]
Patch for v4-19-test

Cherry picks cleanly, compiles, smoke tested
Comment 4 Martin Schwenke 2023-08-15 23:02:32 UTC 
Created attachment 18060 [details]
Patch for v4-18-test

Cherry picks cleanly, compiles, smoke tested
Comment 5 Martin Schwenke 2023-08-15 23:08:14 UTC 
Created attachment 18061 [details]
Patch for v4-17-test

Cherry picks cleanly on top of original pcap updates, from ~12 months ago.

Including patch for v4-17-test on the basis that any use of pcap_open_live() to create a file descriptor for use with tevent is likely to be broken... and v4-17-stable might as well have a working version of this code (sane libpcap support that works with IB).

Compiles, smoke tested.
Comment 6 Volker Lendecke 2023-08-28 12:52:14 UTC 
Comment on attachment 18061 [details]
Patch for v4-17-test

Sorry, I messed up the reviewed-by tags :-(h
Comment 7 Volker Lendecke 2023-08-28 13:02:03 UTC 
Comment on attachment 18061 [details]
Patch for v4-17-test

Having to review when not being formally asked by bugzilla is very confusing to me, sorry :-(
Comment 8 Jule Anger 2023-08-29 08:24:37 UTC 
Pushed to autobuild-v4-{19,18,17}-test.
Comment 9 Samba QA Contact 2023-08-29 09:35:04 UTC 
This bug was referenced in samba v4-19-test:

9f57371128d8ef40448651874857f445be6ed041
58e7d6a945136fe9dd26810f4a22e48d9cf0943f
1af8a09966a82a19d269cc1339232f271dff51bc
Comment 10 Samba QA Contact 2023-08-29 10:30:04 UTC 
This bug was referenced in samba v4-17-test:

74d43dd395b0481d1c7588e80a0e5cb542e7124b
bb905f04b505369e805613e694c2cbb62bd91dee
8d1e4f1d4f183bde3a741e0ffccf2ac7c4f08d4e
Comment 11 Samba QA Contact 2023-08-29 12:28:03 UTC 
This bug was referenced in samba v4-18-test:

550972627b745fe01600fb5bd705472554372f9b
2b5512712e50761117bacd8c78fc3c45e846ee90
5fac5b7b2fd3a61401b46f8dfd9ba38aeb4a5091
Comment 12 Jule Anger 2023-08-29 15:26:07 UTC 
Closing out bug report.

Thanks!
Comment 13 Samba QA Contact 2023-09-04 12:56:11 UTC 
This bug was referenced in samba v4-19-stable (Release samba-4.19.0):

9f57371128d8ef40448651874857f445be6ed041
58e7d6a945136fe9dd26810f4a22e48d9cf0943f
1af8a09966a82a19d269cc1339232f271dff51bc
Comment 14 Samba QA Contact 2023-09-07 09:03:27 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.11):

74d43dd395b0481d1c7588e80a0e5cb542e7124b
bb905f04b505369e805613e694c2cbb62bd91dee
8d1e4f1d4f183bde3a741e0ffccf2ac7c4f08d4e
Comment 15 Samba QA Contact 2023-09-27 08:15:54 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.7):

550972627b745fe01600fb5bd705472554372f9b
2b5512712e50761117bacd8c78fc3c45e846ee90
5fac5b7b2fd3a61401b46f8dfd9ba38aeb4a5091