** CID 1539212: Control flow issues (NO_EFFECT) /ctdb/event/event_tool.c: 216 in print_status_one() ________________________________________________________________________________________________________ *** CID 1539212: Control flow issues (NO_EFFECT) /ctdb/event/event_tool.c: 216 in print_status_one() 210 211 /* 212 * Strip trailing newlines, they are clutter and 213 * interfere with multi-line detection 214 */ 215 p = len - 1; >>> CID 1539212: Control flow issues (NO_EFFECT) >>> This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "p >= 0UL". 216 while (p >= 0 && output[p] == '\n') { 217 output[p] = '\0'; 218 p--; 219 } 220 221 /* If the output is a single line then print it inline */
Also note that documentation was not updated for recent output change, so this can also come in via this bug.
https://gitlab.com/samba-team/samba/-/merge_requests/3201
This bug was referenced in samba master: f01a179abcb33d9da6097f5ae45c7e7df1bc0397 f87f02f6f99157601a6607927305e91835d45ab8
Created attachment 18033 [details] Patch for v4-19-test
Hi Jule, This is ready for v4-19. Thanks.
Pushed to autobuild-v4-19-test.
This bug was referenced in samba v4-19-test: 5b68f98cb7f20eeacf666c1ad7b6303bf488c5dd b604e7b0b95ad0cedb695d84b91379aa107242a3
Closing out bug report. Thanks!
This bug was referenced in samba v4-19-stable (Release samba-4.19.0rc3): 5b68f98cb7f20eeacf666c1ad7b6303bf488c5dd b604e7b0b95ad0cedb695d84b91379aa107242a3