Bug 15417 - Renaming results in NT_STATUS_SHARING_VIOLATION if previously attempted to remove the destination.
Summary: Renaming results in NT_STATUS_SHARING_VIOLATION if previously attempted to re...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.18.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-10 14:39 UTC by Björn Baumbach
Modified: 2023-09-07 09:03 UTC (History)
2 users (show)

See Also:

Attachments
Patch for Samba 4.17 and 4.18, cherry-picked from master (1.23 KB, patch)
2023-07-11 14:13 UTC, Björn Baumbach 		bbaumbach: review? (jra)
slow: review+
Details
Patch for Samba 4.17, cherry-picked from master (1.23 KB, patch)
2023-07-11 15:15 UTC, Björn Baumbach 		slow: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2023-07-10 14:39:13 UTC 
Reproducer:

# mkdir -p /ts/.recycle
# chown -R TEMP\\Administrator /ts
# chattr +i /ts/.recycle
# smbclient //127.0.0.1/ts -UAdministrator%Passw0rd -c "put /etc/hosts test ;
rmdir .recycle ; rename test .recycle/test"

putting file /etc/hosts as \test (91.6 kb/s) (average 91.6 kb/s)
NT_STATUS_ACCESS_DENIED renaming files \test -> \.recycle\test
NT_STATUS_ACCESS_DENIED removing remote directory file \.recycle
NT_STATUS_SHARING_VIOLATION renaming files \test -> \.recycle\test
Comment 1 Björn Baumbach 2023-07-10 14:52:12 UTC 
Ralph has a patch which is coming soon :-)
Comment 2 Samba QA Contact 2023-07-10 21:33:04 UTC 
This bug was referenced in samba master:

4da50463e1b75c06d5f8c066e8b4eff48186afb0
Comment 3 Björn Baumbach 2023-07-11 14:13:52 UTC 
Created attachment 17977 [details]
Patch for Samba 4.17 and 4.18, cherry-picked from master
Comment 4 Ralph Böhme 2023-07-11 14:33:03 UTC 
Iirc 4.17 will also need a backport.
Comment 5 Björn Baumbach 2023-07-11 15:15:26 UTC 
Created attachment 17978 [details]
Patch for Samba 4.17, cherry-picked from master
Comment 6 Ralph Böhme 2023-07-11 15:17:14 UTC 
Reassigning to Jule for inclusion in 4.17 and 4.18.
Comment 7 Björn Baumbach 2023-07-11 15:18:08 UTC 
Comment on attachment 17978 [details]
Patch for Samba 4.17, cherry-picked from master

Patch for 4.17 is the same as for 4.18.
Comment 8 Jule Anger 2023-07-19 15:13:20 UTC 
Pushed to autobuild-v4-{18,17}-test.
Comment 9 Samba QA Contact 2023-07-19 16:24:04 UTC 
This bug was referenced in samba v4-18-test:

96793d42907e28446e093285966d4102b37d08dc
Comment 10 Samba QA Contact 2023-07-19 16:28:03 UTC 
This bug was referenced in samba v4-17-test:

cdce89e434e258dcf6d58e8510b2f5bf42841932
Comment 11 Jule Anger 2023-07-21 12:05:45 UTC 
Closing out bug report.

Thanks!
Comment 12 Samba QA Contact 2023-08-16 16:57:07 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.6):

96793d42907e28446e093285966d4102b37d08dc
Comment 13 Samba QA Contact 2023-09-07 09:03:24 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.11):

cdce89e434e258dcf6d58e8510b2f5bf42841932