Bug 15404 - Backport --pidl-developer fixes
Summary: Backport --pidl-developer fixes
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.18.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-28 10:53 UTC by Stefan Metzmacher
Modified: 2023-07-06 14:01 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-18-test (1.21 KB, patch)
2023-06-28 10:56 UTC, Stefan Metzmacher 		dbagnall: review-
Details
Patch for v4-17-test (2.97 KB, text/plain)
2023-06-28 10:57 UTC, Stefan Metzmacher 		dbagnall: review+
Details
Patch for v4-18-test (2.97 KB, text/plain)
2023-06-28 21:18 UTC, Stefan Metzmacher 		dbagnall: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2023-06-28 10:53:49 UTC 
4.17 and 4.18 won't compile without e26a01a48c4a6ca6f9424ced72eda68e6eb1e7e3
when using --pidl-developer
Comment 1 Stefan Metzmacher 2023-06-28 10:56:44 UTC 
Created attachment 17960 [details]
Patch for v4-18-test
Comment 2 Stefan Metzmacher 2023-06-28 10:57:41 UTC 
Created attachment 17961 [details]
Patch for v4-17-test
Comment 3 Douglas Bagnall 2023-06-28 20:30:08 UTC 
Comment on attachment 17960 [details]
Patch for v4-18-test

4.18 looks to be the wrong patch.
Comment 4 Stefan Metzmacher 2023-06-28 21:18:31 UTC 
Created attachment 17963 [details]
Patch for v4-18-test

Sorry this should be correct patch
Comment 5 Jule Anger 2023-06-30 11:42:32 UTC 
Pushed to autobuild-v4-{18,17}-test.
BUG tag added.
Comment 6 Samba QA Contact 2023-06-30 12:45:03 UTC 
This bug was referenced in samba v4-17-test:

c366a064c8fc72af5a531de3f567253bcbb86d7a
Comment 7 Samba QA Contact 2023-07-03 08:54:05 UTC 
This bug was referenced in samba v4-18-test:

d35c773e969ff56ee527fbecd385a4a56a878cf0
Comment 8 Jule Anger 2023-07-03 08:57:39 UTC 
Closing out bug report.

Thanks!
Comment 9 Samba QA Contact 2023-07-05 11:35:21 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.4):

d35c773e969ff56ee527fbecd385a4a56a878cf0
Comment 10 Samba QA Contact 2023-07-06 14:01:13 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.9):

c366a064c8fc72af5a531de3f567253bcbb86d7a