Bug 15394 - build: missing check for json perl module
Summary: build: missing check for json perl module
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.18.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-12 14:06 UTC by Björn Baumbach
Modified: 2023-08-14 04:41 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Baumbach 2023-06-12 14:06:17 UTC 
Cannot build Samba if the json perl module is not installed:

Can't locate JSON.pm in @INC (you may need to install the JSON module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /root/samba-4.18.3/third_party/heimdal/cf/make-proto.pl line 7.
BEGIN failed--compilation aborted at /root/samba-4.18.3/third_party/heimdal/cf/make-proto.pl line 7.

configure script should check for the json perl module.
Comment 1 Andrew Bartlett 2023-06-24 20:09:41 UTC 
Can you check if Heimdal with https://github.com/heimdal/heimdal/pull/1176 (or perhaps even more importantly, Samba's Heimdal patched with that patch) builds on the platforms you are concerned about?

We are likely to import Heimdal with this and ideally wouldn't want to go from 'need perl module' to 'need newer perl' as that is harder.
Comment 2 Samba QA Contact 2023-08-14 04:41:04 UTC 
This bug was referenced in samba master:

8744e5df7779692862b0f6508e83290c35d267a5