Bug 15383 - Remove comments about deprecated 'write cache size'
Summary: Remove comments about deprecated 'write cache size'
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 4.18.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba Documentation QA Contact~
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-02 06:36 UTC by Jones Syue
Modified: 2023-07-05 11:34 UTC (History)
2 users (show)

See Also:

Attachments
Patch for v4-18-test (6.51 KB, patch)
2023-06-05 01:07 UTC, Jones Syue 		slow: review+
vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jones Syue 2023-06-02 06:36:08 UTC 
The option 'write cache size' was removed since samba-4.12 version:
https://wiki.samba.org/index.php/Samba_4.12_Features_added/changed
https://git.samba.org/?p=samba.git;a=commit;h=3fea05e0
https://git.samba.org/?p=samba.git;a=commit;h=728fabea

It is supposed to remove comments about deprecated 'write cache size', 
in order to avoid confusion when reading source code and documents.

patch will follow.
Comment 2 Samba QA Contact 2023-06-02 09:49:03 UTC 
This bug was referenced in samba master:

9c24f853a84e1435235ba58ffcaaeff7dd80f6aa
Comment 3 Jones Syue 2023-06-05 01:07:58 UTC 
Created attachment 17906 [details]
Patch for v4-18-test

Patch for 4.18 cherry-picked from master.
Comment 4 Jule Anger 2023-06-09 12:19:00 UTC 
Pushed to autobuild-v4-18-test.
Comment 5 Samba QA Contact 2023-06-12 08:26:12 UTC 
This bug was referenced in samba v4-18-test:

d49f9f4be7d825153026b2f63101fd89baa40ceb
Comment 6 Jule Anger 2023-06-12 08:30:02 UTC 
Closing out bug report.

Thanks!
Comment 7 Samba QA Contact 2023-07-05 11:34:39 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.4):

d49f9f4be7d825153026b2f63101fd89baa40ceb