Bug 15333 - smb_strtox.c wrapper around strtoul assumes glibc implementation
Summary: smb_strtox.c wrapper around strtoul assumes glibc implementation
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-13 14:04 UTC by Andrew Walker
Modified: 2023-03-13 14:04 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2023-03-13 14:04:54 UTC 
Non glibc implementations of strtol, strtoul, and friends may set errno to EINVAL in case conversion isn't performed. We already perform replacement of strtoull and strtoll in replace.c and so precedent is to simply detect / replace with glibc-compatible variant.

gitlab MR: https://gitlab.com/samba-team/samba/-/merge_requests/2974/diffs