Bug 15329 - Reduce flapping of ridalloc test
Summary: Reduce flapping of ridalloc test
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: 4.18.0rc4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-09 07:36 UTC by Andrew Bartlett
Modified: 2023-05-11 07:11 UTC (History)
1 user (show)

See Also:

Attachments
Patch in master backported to Samba 4.17 (17.31 KB, patch)
2023-03-15 19:30 UTC, Andrew Bartlett 		jsutton: review+
Details
Patch in master backported to Samba 4.18 (13.98 KB, patch)
2023-03-15 19:32 UTC, Andrew Bartlett 		jsutton: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2023-03-09 07:36:04 UTC 
The samba4.drs.ridalloc_exop.python is known to have been flapping for years, per https://lists.samba.org/archive/samba-cvs/2019-January/118438.html and flaps due to behaviour in our join code around links to deleted objects.

The commit at the end of the process would notice that the link target is now deleted and expected to return a signal to retry with GET_TGT, but by this stage it is too late.

This patch allows this case to continue as if GET_TGT had already have been detected as being useful earlier in the process. 

This, rather than a more invasive change, is made to avoid upsetting our otherwise well-behaved replication infrastructure.
Comment 1 Samba QA Contact 2023-03-14 07:17:22 UTC 
This bug was referenced in samba master:

2d41bcce83a976b85636c92d6fc38c63fdde5431
bfc33b47bb428233e100f75e7a725ac52179f823
Comment 2 Andrew Bartlett 2023-03-15 19:30:25 UTC 
Created attachment 17827 [details]
Patch in master backported to Samba 4.17
Comment 3 Andrew Bartlett 2023-03-15 19:32:57 UTC 
Created attachment 17828 [details]
Patch in master backported to Samba 4.18
Comment 4 Andrew Bartlett 2023-03-15 21:37:19 UTC 
Assigning to Jule for 4.17.next and 4.18.next
Comment 5 Jule Anger 2023-03-29 19:02:34 UTC 
Pushed to autobuild-v4-{18,17}-test.
Comment 6 Samba QA Contact 2023-03-30 16:11:39 UTC 
This bug was referenced in samba v4-17-test:

3ecdec683b60cf100b1c031841b709c91191c8f2
eaff4ef61624276b16dc0dcb11868e2778d2e46f
e2df45934ab415732f7f0377601774119b37e7b3
Comment 7 Samba QA Contact 2023-04-05 11:42:28 UTC 
This bug was referenced in samba v4-18-test:

e804b5b7808f5fafaf61c19476cee98c475fab8a
50f68094f68078072510d9193e72eef56c70c6d5
Comment 8 Jule Anger 2023-04-05 11:55:26 UTC 
Closing out bug report.

Thanks!
Comment 9 Samba QA Contact 2023-04-19 10:24:04 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.2):

e804b5b7808f5fafaf61c19476cee98c475fab8a
50f68094f68078072510d9193e72eef56c70c6d5
Comment 10 Samba QA Contact 2023-05-11 07:11:12 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.8):

3ecdec683b60cf100b1c031841b709c91191c8f2
eaff4ef61624276b16dc0dcb11868e2778d2e46f
e2df45934ab415732f7f0377601774119b37e7b3