Bug 15325 - dsgetdcname: assumes local system uses IPv4
Summary: dsgetdcname: assumes local system uses IPv4
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
: 9792 (view as bug list)
Depends on:
Reported: 2023-03-06 20:15 UTC by Nathaniel W. Turner
Modified: 2023-05-31 16:10 UTC (History)
2 users (show)

See Also:

git-am fix for 4.18.next, 4.17.next (4.12 KB, patch)
2023-03-09 21:27 UTC, Jeremy Allison
jra: review? (dmulder)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathaniel W. Turner 2023-03-06 20:15:54 UTC
The dsgetdcname() function assumes the local system has IPv4 connectivity. In a pure-IPv6 setup, this breaks Active Directory support.

Jeremy and I discussed this back in September (and then I got busy for a while) in  this thread: https://lists.samba.org/archive/samba-technical/2022-September/137633.html
Comment 1 Nathaniel W. Turner 2023-03-06 20:20:22 UTC
Slight clarification:

If a DC is configured to support both IPv4 and IPv6, and a client in that
environment is configured IPv6-only (e.g. as part of a transition to
all-IPv6), it looks like the logic will pick one of the DC's IPv4 addresses
and ignore it's IPv6 addresses.
Comment 2 Samba QA Contact 2023-03-09 19:13:04 UTC
This bug was referenced in samba master:

Comment 3 Jeremy Allison 2023-03-09 21:27:52 UTC
Created attachment 17798 [details]
git-am fix for 4.18.next, 4.17.next

Cherry-picked from master. Applies cleanly to 4.18.next, 4.17.next.
Comment 4 Björn Jacke 2023-03-11 10:02:15 UTC
*** Bug 9792 has been marked as a duplicate of this bug. ***
Comment 5 Jule Anger 2023-05-05 11:49:23 UTC
Pushed to autobuild-v4-{18,17}-test.
Comment 6 Samba QA Contact 2023-05-05 14:02:03 UTC
This bug was referenced in samba v4-17-test:

Comment 7 Samba QA Contact 2023-05-08 10:18:04 UTC
This bug was referenced in samba v4-18-test:

Comment 8 Jule Anger 2023-05-08 11:57:04 UTC
Closing out bug report.

Comment 9 Samba QA Contact 2023-05-11 07:10:47 UTC
This bug was referenced in samba v4-17-stable (Release samba-4.17.8):

Comment 10 Samba QA Contact 2023-05-31 16:10:29 UTC
This bug was referenced in samba v4-18-stable (Release samba-4.18.3):