Bug 15316 - Flapping tests in samba_tool_drs_show_repl.py
Summary: Flapping tests in samba_tool_drs_show_repl.py
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 15343
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-23 04:04 UTC by Rob van der Linde
Modified: 2023-04-19 10:23 UTC (History)
1 user (show)

See Also:

Attachments
patch in master backported to Samba 4.18 (55.27 KB, patch)
2023-03-29 20:27 UTC, Andrew Bartlett 		dbagnall: review+
abartlet: ci-passed+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob van der Linde 2023-02-23 04:04:18 UTC 
The tests in samba_tool_drs_show_repl.py are failing randomly.

Two things, first of all a couple of tests are using hardcoded values and need to be made generic.

The other thing, the tests are using the wrong dc, the "env" variable is picked up from the loop above it as well and contains the dc "schema_pair_dc" but the test was using another dc.
Comment 1 Samba QA Contact 2023-02-23 23:34:06 UTC 
This bug was referenced in samba master:

1368e359b2a75b6b683aff274b2b2084f3cd469b
3687ab318a9553883d8c0d1214e2d49b83ec91ba
Comment 2 Andrew Bartlett 2023-03-29 20:27:33 UTC 
Created attachment 17849 [details]
patch in master backported to Samba 4.18
Comment 3 Jule Anger 2023-04-05 11:57:52 UTC 
Pushed to autobuild-v4-18-test.
Comment 4 Samba QA Contact 2023-04-05 13:03:04 UTC 
This bug was referenced in samba v4-18-test:

e9f5d1c03bcb800fc6e01a11c49cf5c193d6a00c
5382bf6344cc417144136957cc5e04f6f0aa1fcd
7e6dc45f7e61dfad2d56ff58f31664cefb96281c
Comment 5 Jule Anger 2023-04-05 13:08:40 UTC 
Closing out bug report.

Thanks!
Comment 6 Samba QA Contact 2023-04-19 10:23:16 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.2):

e9f5d1c03bcb800fc6e01a11c49cf5c193d6a00c
5382bf6344cc417144136957cc5e04f6f0aa1fcd
7e6dc45f7e61dfad2d56ff58f31664cefb96281c