Bug 15308 - Avoid that tests fail because other tests didn't do cleanup on failure
Summary: Avoid that tests fail because other tests didn't do cleanup on failure
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: 4.18.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-10 08:16 UTC by Andreas Schneider
Modified: 2024-02-13 20:28 UTC (History)
3 users (show)

See Also:

Attachments
patch for 4.18 (59.49 KB, patch)
2023-02-21 07:00 UTC, Andreas Schneider 		no flags Details
patch for 4.18 (58.25 KB, patch)
2023-02-21 07:01 UTC, Andreas Schneider 		ab: review+
Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2023-02-10 08:16:14 UTC 
Avoid that tests fail because other tests didn't do cleanup on failure.


Merge request and patch will follow.
Comment 1 Samba QA Contact 2023-02-20 22:59:04 UTC 
This bug was referenced in samba master:

93c7bbf4d2db73116e5de564b428d6d30504bd5c
5595765d4e5918abe8d68423a8036f99675e64e7
a3b80b656f16049772005bd7b00451aaa5df2dd6
a78c38e1f114858bd72738c752d27ef4b4358488
0bcdba952ec887139517841b8882bd6e10c00267
af1324e3be28773e0b8cc827c669812e4c257989
e846a9df60323a77e8222f27be8d31b326ce8d6a
8ff1ccc6d6d8804be55f5549910aa11c6a9a7664
ae315397a653ec2249b89e246eb46589d4542f75
af27b1d37573d165983933d3789a18b12fad0272
804fb07259b87e80993b1916935b626906e04580
c4dba61e3691a1fd15eb63ee69224457102bf961
69442ae1072eb6dc4c9903122d613c1756ca57c7
a4307072d6ea5ddef5b37aa361e9e9f16f7254e7
Comment 2 Andreas Schneider 2023-02-21 07:00:34 UTC 
Created attachment 17761 [details]
patch for 4.18
Comment 3 Andreas Schneider 2023-02-21 07:01:33 UTC 
Created attachment 17762 [details]
patch for 4.18
Comment 4 Alexander Bokovoy 2023-02-21 07:08:39 UTC 
Comment on attachment 17762 [details]
patch for 4.18

LGTM
Comment 5 Andreas Schneider 2023-02-22 07:10:08 UTC 
Jule, can you please apply the patch? Thanks!
Comment 6 Jule Anger 2023-02-23 08:44:26 UTC 
Pushed to autobuild-v4-18-test.
Comment 7 Samba QA Contact 2023-02-24 09:51:03 UTC 
This bug was referenced in samba v4-18-test:

67639f6d9ad481c4c15555d6202db8aa0132c0de
f15a1413571861eafb7c6a84c70fd684732a1823
820970ab5ec1e70af751cfefeea609230a52a058
d45706e26538b689be7d565c185f87f47735f801
359095e8ddda1db6c04f1edc32c13bf2c452c12f
074e0c2783aae1e220f4e195b325374b440e3a8d
889839858fe50337bfbea0b52fb52f3816616713
5ce320a06e049a6dc7e407e34f3563fafb272db0
bebf313dcb05af6ba7dbc75ea64ad8270562ba1b
9e8cc236bd3111b81289fe35187e6d8e5d843ea8
8739c9c72ddb346642e4adf98b1fb8f4440cf288
b7b61025b65164327f5d375de38e92f0b6ddc4cf
b925ac8094fb62a6247d066bc17b374d24abcd5b
6191dbda1932d8eab59a593ce5ef979143ce3a46
Comment 8 Jule Anger 2023-02-24 11:07:23 UTC 
Closing out bug report.

Thanks!
Comment 9 Samba QA Contact 2023-03-01 12:46:53 UTC 
This bug was referenced in samba v4-18-stable (Release samba-4.18.0rc4):

67639f6d9ad481c4c15555d6202db8aa0132c0de
f15a1413571861eafb7c6a84c70fd684732a1823
820970ab5ec1e70af751cfefeea609230a52a058
d45706e26538b689be7d565c185f87f47735f801
359095e8ddda1db6c04f1edc32c13bf2c452c12f
074e0c2783aae1e220f4e195b325374b440e3a8d
889839858fe50337bfbea0b52fb52f3816616713
5ce320a06e049a6dc7e407e34f3563fafb272db0
bebf313dcb05af6ba7dbc75ea64ad8270562ba1b
9e8cc236bd3111b81289fe35187e6d8e5d843ea8
8739c9c72ddb346642e4adf98b1fb8f4440cf288
b7b61025b65164327f5d375de38e92f0b6ddc4cf
b925ac8094fb62a6247d066bc17b374d24abcd5b
6191dbda1932d8eab59a593ce5ef979143ce3a46