Bug 15258 - filter-subunit is inefficient with large numbers of knownfails
Summary: filter-subunit is inefficient with large numbers of knownfails
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Test infrastructure (show other bugs)
Version: 4.17.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: 15238
  Show dependency tree / graph
 
Reported: 2022-12-06 04:19 UTC by Andrew Bartlett
Modified: 2022-12-19 06:29 UTC (History)
3 users (show)

See Also:

Attachments
Patch for v4-17-test (3.75 KB, text/plain)
2022-12-13 22:52 UTC, Stefan Metzmacher 		abartlet: review+
Details
Patch for v4-16-test (3.75 KB, text/plain)
2022-12-13 22:53 UTC, Stefan Metzmacher 		abartlet: review+
Details
Patch for v4-15-test (3.75 KB, text/plain)
2022-12-13 22:54 UTC, Stefan Metzmacher 		abartlet: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2022-12-06 04:19:49 UTC 
filter-subunit will build a new regular expression to match for every line in the knownfail files for every test that is output.

With the combination tests we now add, this can be a lot of lines. 

This bug filed so we can track the backport of a patch being proposed for master  in https://gitlab.com/samba-team/samba/-/merge_requests/2803
Comment 1 Samba QA Contact 2022-12-13 14:07:46 UTC 
This bug was referenced in samba master:

22128c718cadd34af892df102bd52df6a6b03303
Comment 2 Stefan Metzmacher 2022-12-13 22:52:49 UTC 
Created attachment 17689 [details]
Patch for v4-17-test
Comment 3 Stefan Metzmacher 2022-12-13 22:53:59 UTC 
Created attachment 17690 [details]
Patch for v4-16-test
Comment 4 Stefan Metzmacher 2022-12-13 22:54:53 UTC 
Created attachment 17691 [details]
Patch for v4-15-test
Comment 5 Samba QA Contact 2022-12-14 10:32:11 UTC 
This bug was referenced in samba v4-15-test:

26249f6c06591ba87d45e2a0f7322082a157fa06
Comment 6 Samba QA Contact 2022-12-14 11:34:30 UTC 
This bug was referenced in samba v4-16-test:

4d099f8f678373736a195dfe367bb688c72036b9
Comment 7 Samba QA Contact 2022-12-14 12:41:54 UTC 
This bug was referenced in samba v4-17-test:

fd50943b2a470265ceb0e84de3a8e0d83c287138
Comment 8 Samba QA Contact 2022-12-15 16:32:56 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.4):

fd50943b2a470265ceb0e84de3a8e0d83c287138
Comment 9 Samba QA Contact 2022-12-15 16:34:22 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.13):

26249f6c06591ba87d45e2a0f7322082a157fa06
Comment 10 Samba QA Contact 2022-12-15 16:36:18 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.8):

4d099f8f678373736a195dfe367bb688c72036b9