we should not try to compile and link against krb5 libs if there's no krb5.h available. metze
What exactly is the problem here? Is it not building at all, or is it just not building with kerberos?
the problem is that we check for krb5.h but didn't check the result of this test. then we maynot have HAVE_KRB5_H defined, but continue with the krb5.,etc lib tests and if we found -lkrb5 we define HABE_KRB5 then we try to build with kerberos support. - we try to link the krb5,gssapi,etc. libs and don't have krb5 support compiled in. see this mails: http://lists.samba.org/pipermail/samba-technical/2003-June/045136.html http://lists.samba.org/pipermail/samba-technical/2003-June/045159.html http://lists.samba.org/pipermail/samba-technical/2003-June/045162.html http://lists.samba.org/pipermail/samba-technical/2003-June/045163.html
I've fixed the indentation of the Kerberos autoconf detection code in configure.in as it was impossible to work out what actually happening. Also, I've applied the gist of your patch but as Jelmer suggested not introduced an additional level of indentation. The message produced when krb5.h is not found is now an error as the user has specified they want AD support and will not get it. No-one reads the output of configure unless it doesn't work so a warning in this case would be useless.
Your patch broke all builds on hosts without krb5.h ! we should only use AC_MSG_ERR when --with-ads is specified! and AC_MSG_WARN when --with-ads is NOT specified! and when we warn don't link to any krb5 lib!
Now that I have restored my development system after accidentally trashing the root filesystem, I've checked in my fix for this. It should satisfy all the conditions: - die if ADS support requested and no krb5.h - don't update LIBS or CFLAGS if ADS support not possible/requested Metze, let me know how it goes.
Jim, I think I know how to describe this bug - install the krb5-lib RPM but not the krb5-devel package! It's similar to the pam problem. You must have the devel package installed as well as the library to build Samba.
Does that mean you're saying you _must_ have the krb5-devel installed if you have the krb5-libs package installed? Or are you just re-stating the original problem?
Both. (-: You must have krb5-libs and krb5-devel which is also a restatement of the problem. I was having trouble understanding the rationale for this bug until I thought of this.
originally reported against 3.0.0beta1. CLeaning out non-production release versions.
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.