Bug 15193 - Allow rebuild of Centos 8 images after move to vault for Samba 4.15
Summary: Allow rebuild of Centos 8 images after move to vault for Samba 4.15
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.15.10
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks: CVE-2022-3437
  Show dependency tree / graph
 
Reported: 2022-10-06 19:53 UTC by Andrew Bartlett
Modified: 2022-10-25 09:45 UTC (History)
1 user (show)

See Also:

Attachments
Patch for Samba 4.15 to allow rebuilding the lost CI image (15.30 KB, patch)
2022-10-10 00:05 UTC, Andrew Bartlett 		jsutton: review+
abartlet: ci-passed+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2022-10-06 19:53:41 UTC 
We need to backport the switch to vault.centos.org to ensure we can rebuild our Centos 8 CI images
Comment 1 Andrew Bartlett 2022-10-10 00:05:51 UTC 
Created attachment 17547 [details]
Patch for Samba 4.15 to allow rebuilding the lost CI image

CI pipeline running here is looking good so far: https://gitlab.com/samba-team/devel/samba/-/pipelines/662259378

CentOS8s Job: https://gitlab.com/samba-team/devel/samba/-/jobs/3147707122
Comment 2 Jennifer Sutton 2022-10-10 01:25:34 UTC 
Comment on attachment 17547 [details]
Patch for Samba 4.15 to allow rebuilding the lost CI image

I notice we now have this line:

yum config-manager --set-enabled powertools -y || \
     yum config-manager --set-enabled powertools -y

The first command used to specify 'PowerTools' instead of 'powertools', but now the commands are duplicates of each other. I guessed this was possibly an artifact of a merge conflict, but those lines are actually the same in master. Hence I won't hold up the review over them.
Comment 3 Andrew Bartlett 2022-10-10 01:29:10 UTC 
(In reply to Joseph Sutton from comment #2)
Thanks.  

What is even worse is that fixing that would change the sha1sum again and really not be worth it, but we should fix that in master when we have to change something else. 

Assigning to Jule for inclusion in Samba 4.15's next security release (needed to allow testing security releases with GitLab pipelines).
Comment 4 Samba QA Contact 2022-10-25 09:12:27 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.11):

6881b17bf277c7b4958f66de7af5bdbdecc32eac
ae64b3bfc1823c4efd03f506f6908722e8fa513b
52ed3d07fd5269163b006985e56921cf015a32f9
9f658aa5fe2d64780b4cd25a456ae0c6e4b7c2a4
Comment 5 Jule Anger 2022-10-25 09:33:47 UTC 
Closing out bug report.

Thanks!
Comment 6 Samba QA Contact 2022-10-25 09:45:44 UTC 
This bug was referenced in samba v4-15-test:

6881b17bf277c7b4958f66de7af5bdbdecc32eac
ae64b3bfc1823c4efd03f506f6908722e8fa513b
52ed3d07fd5269163b006985e56921cf015a32f9
9f658aa5fe2d64780b4cd25a456ae0c6e4b7c2a4