Bug 15192 - Remove special case for O_CREAT in SMB_VFS_OPENAT from vfs_glusterfs
Summary: Remove special case for O_CREAT in SMB_VFS_OPENAT from vfs_glusterfs
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.17.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-06 07:34 UTC by Anoop C S
Modified: 2022-10-19 12:25 UTC (History)
2 users (show)

See Also:

Attachments
patch for v4-17 (3.67 KB, patch)
2022-10-06 15:47 UTC, Anoop C S 		slow: review+
gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anoop C S 2022-10-06 07:34:40 UTC 
Due to a bug[1] in glfs_openat() O_CREAT open flag was handled separately via glfs_creat() in vfs_gluster_openat(). With recent fix[2] O_CREAT is now correctly handled and thus corresponding special case can be taken out making SMB_VFS_OPENAT implementation safe against symlink races.


[1] https://github.com/gluster/glusterfs/issues/3838
[2] https://github.com/gluster/glusterfs/pull/3839
Comment 1 Anoop C S 2022-10-06 15:47:46 UTC 
Created attachment 17544 [details]
patch for v4-17
Comment 2 Anoop C S 2022-10-06 15:49:05 UTC 
Re-assigning to Jule for v4-17.next
Comment 3 Jule Anger 2022-10-07 08:54:22 UTC 
Pushed to autobuild-v4-17-test.
BUG tag added.
Comment 4 Ralph Böhme 2022-10-07 08:55:30 UTC 
(In reply to Jule Anger from comment #3)
Adding the missing RB+ for the backport...
Comment 5 Samba QA Contact 2022-10-07 10:00:44 UTC 
This bug was referenced in samba v4-17-test:

cb27978c461e276d31029474454ede3fc37483bf
Comment 6 Guenther Deschner 2022-10-07 10:06:42 UTC 
Comment on attachment 17544 [details]
patch for v4-17

LGTM, thanks for taking care of this!
Comment 7 Jule Anger 2022-10-07 13:08:20 UTC 
Closing out bug report.

Thanks!
Comment 8 Samba QA Contact 2022-10-19 12:25:54 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.1):

cb27978c461e276d31029474454ede3fc37483bf