Bug 15182 - Flush on a named stream never completes
Summary: Flush on a named stream never completes
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.17.0rc5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-15 19:31 UTC by suinn
Modified: 2022-09-21 16:13 UTC (History)
2 users (show)

See Also:


Attachments
Packet trace (79.76 KB, application/octet-stream)
2022-09-15 19:31 UTC, suinn
no flags Details
git-am fix for master. (8.59 KB, patch)
2022-09-20 22:05 UTC, Jeremy Allison
no flags Details
git-am fix for master. (8.58 KB, patch)
2022-09-21 00:23 UTC, Jeremy Allison
jra: review? (slow)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description suinn 2022-09-15 19:31:56 UTC
Created attachment 17520 [details]
Packet trace

From SNIA 2022 in Fremont, macOS SMB Client unit test testUpdateLeaseResourceFork ends up sending a SMB Flush on a named stream and the Samba server returns STATUS_PENDING but never sends the actual Flush reply.

Working with Jeremy Allison at SNIA for this bug.
Comment 1 Jeremy Allison 2022-09-15 21:05:34 UTC
I have tracked this down. vfs_fruit needs to add fsync_send_fn/fsync_recv_fn handling, otherwise it passes a fake fd down to the streams_xattr module which causes the flush never to complete.
Comment 2 Jeremy Allison 2022-09-20 22:05:56 UTC
Created attachment 17524 [details]
git-am fix for master.

Fix in gitlab-ci. Adds a test.