Bug 15161 - assert failed: !is_named_stream(smb_fname)") at ../../lib/util/fault.c:197
Summary: assert failed: !is_named_stream(smb_fname)") at ../../lib/util/fault.c:197
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-01 13:51 UTC by Ralph Böhme
Modified: 2023-07-03 17:59 UTC (History)
1 user (show)

See Also:

Attachments
Patch for 4.17 cherry-picked from master (8.19 KB, patch)
2022-09-02 16:43 UTC, Ralph Böhme 		vl: review+
Details
Patch for 4.15 and 4.16 backported from master (7.69 KB, patch)
2022-09-05 08:19 UTC, Ralph Böhme 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2022-09-01 13:51:08 UTC 
It seems the patches for bug https://bugzilla.samba.org/show_bug.cgi?id=15126 cause a regression. We need a full stackbacktrace to analyse this.
Comment 1 Samba QA Contact 2022-09-02 15:57:11 UTC 
This bug was referenced in samba master:

3dcdab86f13fabb7a8c6ce71c59a565287d11244
201e1969bf31af07e8bd52876ff7f4d72b48a848
3a37e4155c3cd82388652f89b611f2c46fee8525
Comment 2 Ralph Böhme 2022-09-02 16:43:52 UTC 
Created attachment 17505 [details]
Patch for 4.17 cherry-picked from master
Comment 3 Ralph Böhme 2022-09-02 16:45:40 UTC 
Fwiw, the patch for 4.16 currently running in a pipeline in gitlab CI:

https://gitlab.com/samba-team/devel/samba/-/pipelines/630008933

The core change is quite different, so the patches needs additional CI testing and review.
Comment 4 Ralph Böhme 2022-09-05 08:19:32 UTC 
Created attachment 17508 [details]
Patch for 4.15 and 4.16 backported from master
Comment 5 Ralph Böhme 2022-09-05 09:25:33 UTC 
Reassigning to Jule for inclusion in 4.15, 4.16 and 4.17.
Comment 6 Jule Anger 2022-09-06 06:30:24 UTC 
Pushed to autobuild-v4-{17,16,15}-test.
Comment 7 Samba QA Contact 2022-09-06 07:32:12 UTC 
This bug was referenced in samba v4-15-test:

c5796b0c7a35f2cc96cab3c63502c21b6153abd8
fa6012b63ab36704dfcfd6f95958ae0e089a94b5
6b5792b0a2ca1b7d4114272165968aaea673fceb
Comment 8 Samba QA Contact 2022-09-06 08:09:19 UTC 
This bug was referenced in samba v4-17-test:

3139a1063a07ddb8a0df705bdc67d179969960b2
930380d4746f57e3d8ae9b6e9b9e37fc12ad890d
ed1d01126160d49aea9088805120f95050510fe6
Comment 9 Samba QA Contact 2022-09-06 08:50:10 UTC 
This bug was referenced in samba v4-16-test:

b807f3624d1f720ad3d60c7ee51a69d89183633f
7c83b7788ec022551a2fd9381a1a5ff8e4adf5bc
1761ad3dff2e887593a06a9d9d47828427133bfd
Comment 10 Samba QA Contact 2022-09-06 14:26:22 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.0rc5):

3139a1063a07ddb8a0df705bdc67d179969960b2
930380d4746f57e3d8ae9b6e9b9e37fc12ad890d
ed1d01126160d49aea9088805120f95050510fe6
Comment 11 Jule Anger 2022-09-06 14:34:09 UTC 
Closing out bug report.

Thanks!
Comment 12 Samba QA Contact 2022-09-07 19:03:06 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.5):

b807f3624d1f720ad3d60c7ee51a69d89183633f
7c83b7788ec022551a2fd9381a1a5ff8e4adf5bc
1761ad3dff2e887593a06a9d9d47828427133bfd
Comment 13 Samba QA Contact 2022-09-28 15:42:28 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.10):

c5796b0c7a35f2cc96cab3c63502c21b6153abd8
fa6012b63ab36704dfcfd6f95958ae0e089a94b5
6b5792b0a2ca1b7d4114272165968aaea673fceb
Comment 14 Mikhail T. 2023-07-03 17:59:34 UTC 
(In reply to Ralph Böhme from comment #3)
> the patch for 4.16 currently running in a pipeline

Using 4.16.10 here on FreeBSD-13, I'm still seeing this message, when iPhone tries to browse an SMB-share:

[2023/07/03 13:12:06.318563,  0] ../../lib/util/fault.c:176(smb_panic_log)
  INTERNAL ERROR: assert failed: !is_named_stream(smb_fname) in pid 54821 (4.16.10)
[2023/07/03 13:12:06.318580,  0] ../../lib/util/fault.c:181(smb_panic_log)
  If you are running a recent Samba version, and if you think this problem is not yet fixed in the latest versions, please consider reporting this bug, see https://wiki.samba.org/index.php/Bug_Reporting
[2023/07/03 13:12:06.318606,  0] ../../lib/util/fault.c:182(smb_panic_log)
  ===============================================================
[2023/07/03 13:12:06.318622,  0] ../../lib/util/fault.c:184(smb_panic_log)
  PANIC (pid 54821): assert failed: !is_named_stream(smb_fname) in 4.16.10
[2023/07/03 13:12:06.319123,  0] ../../lib/util/fault.c:245(log_stack_trace)
  BACKTRACE:
   #0 log_stack_trace + 0x35 [ip=0xe22d932c775] [sp=0xe22cf77ffa0]
   #1 smb_panic + 0x11 [ip=0xe22d932c971] [sp=0xe22cf780870]
   #2 vfs_default_init + 0x18fe [ip=0xe22d254b4ee] [sp=0xe22cf780890]
   #3 samba_init_module + 0x9ea4 [ip=0xe23210931a4] [sp=0xe22cf7808c0]
   #4 samba_init_module + 0x4dbb [ip=0xe232108e0bb] [sp=0xe22cf780900]
   #5 synthetic_pathref + 0x6f [ip=0xe22d255247f] [sp=0xe22cf780920]
   #6 samba_init_module + 0x86ff [ip=0xe23210919ff] [sp=0xe22cf780950]
   #7 smbd_dirptr_lanman2_entry + 0x26d [ip=0xe22d2586b5d] [sp=0xe22cf780a70]
   #8 smbd_smb2_request_process_query_directory + 0xece [ip=0xe22d25ef23e] [sp=0xe22cf780c40]
   #9 smbd_smb2_request_process_query_directory + 0x975 [ip=0xe22d25eece5] [sp=0xe22cf780db0]
   #10 smbd_smb2_request_dispatch + 0xa54 [ip=0xe22d25d8f34] [sp=0xe22cf780e90]
   #11 smbd_smb2_process_negprot + 0x2568 [ip=0xe22d25dd0e8] [sp=0xe22cf780f20]
   #12 tevent_common_invoke_fd_handler + 0x9d [ip=0xe22dd459b7d] [sp=0xe22cf780fc0]
   #13 tevent_context_same_loop + 0xd31 [ip=0xe22dd45cba1] [sp=0xe22cf781000]
   #14 _tevent_loop_once + 0xe0 [ip=0xe22dd458af0] [sp=0xe22cf781060]
   #15 tevent_common_loop_wait + 0x32 [ip=0xe22dd458d42] [sp=0xe22cf7810a0]
   #16 smbd_process + 0x79c [ip=0xe22d25c6d1c] [sp=0xe22cf7810d0]
   #17 main + 0x43b6 [ip=0xe1aaeedada6] [sp=0xe22cf781170]
   #18 tevent_common_invoke_fd_handler + 0x9d [ip=0xe22dd459b7d] [sp=0xe22cf781240]
   #19 tevent_context_same_loop + 0xd31 [ip=0xe22dd45cba1] [sp=0xe22cf781280]
   #20 _tevent_loop_once + 0xe0 [ip=0xe22dd458af0] [sp=0xe22cf7812e0]
   #21 tevent_common_loop_wait + 0x32 [ip=0xe22dd458d42] [sp=0xe22cf781320]
   #22 main + 0x28ff [ip=0xe1aaeed92ef] [sp=0xe22cf781350]
   #23 main + 0xda6 [ip=0xe1aaeed7796] [sp=0xe22cf781380]
   #24 _start + 0x10d [ip=0xe1aaeed656d] [sp=0xe22cf7816a0]
   #25 <unknown symbol> [ip=0xe22d0610008] [sp=0xe22cf7816b0]
[2023/07/03 13:12:07.031076,  0] ../../source3/lib/dumpcore.c:310(dump_core)
  unable to change to %N.core
  refusing to dump core