Bug 15159 - Cross-node multi-channel reconnects result in SMB2 Negotiate returning NT_STATUS_NOT_SUPPORTED
Summary: Cross-node multi-channel reconnects result in SMB2 Negotiate returning NT_STA...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.17.0rc4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/-...
Keywords:
Depends on:
Blocks: 15200
  Show dependency treegraph
 
Reported: 2022-08-30 19:06 UTC by Stefan Metzmacher
Modified: 2022-12-15 16:35 UTC (History)
3 users (show)

See Also:


Attachments
Patches for v4-17-test (20.81 KB, patch)
2022-09-05 09:27 UTC, Stefan Metzmacher
slow: review+
Details
Patches for v4-16-test (20.81 KB, patch)
2022-09-05 09:28 UTC, Stefan Metzmacher
slow: review+
Details
Patches for v4-15-test (20.81 KB, patch)
2022-09-05 09:30 UTC, Stefan Metzmacher
slow: review+
Details
Patches for v4-16-test (14.27 KB, patch)
2022-10-10 07:09 UTC, Stefan Metzmacher
slow: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2022-08-30 19:06:04 UTC
If a client disconnected all its interfaces and reconnects when
the come back, it will likely start from any ip address returned
dns, which means it can try to connect to a different ctdb node.
The old node may not noticed the disconnect and still holds
the client_guid based smbd.
    
Up to know the new node returned NT_STATUS_NOT_SUPPORTED to
the SMB2 Negotiate request, as messaging_send_iov[_from]() will
return -1/ENOSYS if a file descriptor os passed to a process on
a different node.
Comment 1 Samba QA Contact 2022-09-02 21:00:04 UTC
This bug was referenced in samba master:

3fd18a0d5b77a9f78c595852c342d4c8c33fac61
0efcfaa49c3d61f2c8116ebafd55b72d3277d0d8
21ef01e7b8368caa050ed82b9d787d1679220b2b
8591d9424371e173b079d5c8a267ea4c2cb266ad
Comment 2 Stefan Metzmacher 2022-09-05 09:27:52 UTC
Created attachment 17509 [details]
Patches for v4-17-test
Comment 3 Stefan Metzmacher 2022-09-05 09:28:58 UTC
Created attachment 17510 [details]
Patches for v4-16-test
Comment 4 Stefan Metzmacher 2022-09-05 09:30:44 UTC
Created attachment 17511 [details]
Patches for v4-15-test
Comment 5 Ralph Böhme 2022-09-05 09:42:38 UTC
Reassigning to Jule for inclusion in 4.15, 4.16 and 4.17.
Comment 6 Jule Anger 2022-09-06 09:23:53 UTC
Pushed to autobuild-v4-{17,16,15}-test.
Comment 7 Samba QA Contact 2022-09-06 10:28:04 UTC
This bug was referenced in samba v4-17-test:

fc52fe99d7900d5483c94ad49a0095ddd283354f
64daf27dc730cd432dc902de5b93c3097da335f2
095ee4ce189f12e13cb9d70bd99a670623aa08ae
71c94a076bad166098e1c24e45f866abdd6c8f92
Comment 8 Samba QA Contact 2022-09-06 14:25:57 UTC
This bug was referenced in samba v4-17-stable (Release samba-4.17.0rc5):

fc52fe99d7900d5483c94ad49a0095ddd283354f
64daf27dc730cd432dc902de5b93c3097da335f2
095ee4ce189f12e13cb9d70bd99a670623aa08ae
71c94a076bad166098e1c24e45f866abdd6c8f92
Comment 9 Jule Anger 2022-09-07 18:48:50 UTC
Autobuild failed several times for task samba-ctdb during test.
Comment 10 Stefan Metzmacher 2022-10-10 07:06:00 UTC
(In reply to Jule Anger from comment #9)

Ah, we can't backport the tests as they rely on the new smbstatus --json
Comment 11 Stefan Metzmacher 2022-10-10 07:09:09 UTC
Created attachment 17548 [details]
Patches for v4-16-test

Backport to 4.16 without the tests
Comment 12 Ralph Böhme 2022-10-10 09:33:59 UTC
Reassiging to Jule for inclusion in 4.16.
Comment 13 Ralph Böhme 2022-10-10 09:42:20 UTC
Reassigning to metze due a possible regression:

https://lists.samba.org/archive/samba/2022-September/241887.html
Comment 14 Jeremy Allison 2022-10-10 18:47:52 UTC
Metze, I'll re-review once the possible regression is investigated. Sorry, COVID still slowing me down at the moment :-(.
Comment 15 Stefan Metzmacher 2022-10-12 14:46:31 UTC
Comment on attachment 17548 [details]
Patches for v4-16-test

The additional problem is handled in https://bugzilla.samba.org/show_bug.cgi?id=15200, so it's not a regression...
Comment 16 Ralph Böhme 2022-10-14 09:53:58 UTC
Reassigning again to Jule for inclusion in 4.16.
Comment 17 Jule Anger 2022-10-18 08:29:16 UTC
Pushed to autobuild-v4-16-test
Comment 18 Samba QA Contact 2022-10-18 09:42:03 UTC
This bug was referenced in samba v4-16-test:

ada5ef9d847f17fd00fd1704300258de97c69e6f
52dd57d4b30218b93231cf1a990c8829b0c06033
Comment 19 Jule Anger 2022-10-18 14:16:02 UTC
Closing out bug report.

Thanks!
Comment 20 Samba QA Contact 2022-12-15 16:35:32 UTC
This bug was referenced in samba v4-16-stable (Release samba-4.16.8):

ada5ef9d847f17fd00fd1704300258de97c69e6f
52dd57d4b30218b93231cf1a990c8829b0c06033