Bug 15144 - 4.17.rc1 still uses symlink-race prone unix_convert()
Summary: 4.17.rc1 still uses symlink-race prone unix_convert()
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.17.0rc1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on: 15146
Blocks:
  Show dependency tree / graph
 
Reported: 2022-08-12 17:06 UTC by Jeremy Allison
Modified: 2022-08-23 07:13 UTC (History)
1 user (show)

See Also:

Attachments
git-am fix for 4.17.rc2 (112.90 KB, patch)
2022-08-12 19:34 UTC, Jeremy Allison 		slow: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2022-08-12 17:06:56 UTC 
Placeholder bug so I can back-port the patches in:

https://gitlab.com/samba-team/samba/-/merge_requests/2662

for 4.17.rc2 to eliminate all uses of the old unix_convert() code that uses compound pathnames.

This will make it easier to back-port fixes from master to 4.17.x during its lifetime.
Comment 1 Samba QA Contact 2022-08-12 19:19:11 UTC 
This bug was referenced in samba master:

2818fd6910201fd4a18b921933a0b7392a0a8995
bcba5502282eb6dcc346d7c63aa3218cda2f9bb0
7bd7fa0a0b46ad6826097a1987595e2ab6f83384
4fafc3418931de06ea2d91baca1eef8d904cc4e6
a2a097fc3d6a89fb970c1ea3ea75fde93ddb545e
0a4a27ce48bc7090aa821eea5e56f8d44c686716
2df8a8ab87a1372f2b67880be4454a0285b3104b
f92711f000a3cb658dfb8fffe92ae6bba78b4f91
6c83c674bab8e57ecaf6271eb3a403171bbbacca
4f5d02f8c0efc1520b2113ce656c78483deb7826
c0a1d7c7a8a7f24890e60c7a371498949dec11c2
a3c9eb7931cb4da0dd5bc5d600125979dd1a7df5
245d07ab84852b829c029496618e56782d070e83
da625e4ab4bc670e44fcb6ad7456aa64d0f1f9d2
a92f4f7af0eaa035deebfb1c930ca0cc12d992d5
b5f6809593524e7e9aca1c09ff379e02a1cde61b
07ef9e3029b8cca1b92d900d6ed684ca0ac6afe4
d80bedc3c418b6839b1bde78ba8d3db06611be2a
fcf19d91c09edc6dfbf5bd7cbeedcd641030eb31
d20b60c3200b5e1881cdf4b59da154d1af7e3994
6b1224b22012b54b1ae20b682daf61c877362a7b
22d4f62537199d9454be312a546e251f04022497
88e8bfec59412fdc0e83251fef60b45d2cc3a884
cc638c25e0332d366016880d174d9349940cba3f
78e4aac76df977cea6cdbcfdf082fd3acdffbd95
Comment 2 Jeremy Allison 2022-08-12 19:34:03 UTC 
Created attachment 17473 [details]
git-am fix for 4.17.rc2

Cherry-picked from master.
Comment 3 Samba QA Contact 2022-08-16 19:38:36 UTC 
This bug was referenced in samba v4-17-test:

496b9b45c385d5b89a1d335f157d73824db47004
33d00d7e8819b70861294bbc90726e0306443adb
deb009404a5e6ec6499b3df5aec94ff34675d063
c940c9eae9487840b077742a793d3631b2b8f027
8d09dc1691250e88d3bf11ea2a51b40d0dce8373
8031584e1eb776bafe3f29efbebadfa9bd2666fb
3a944329c31ac665940c3122547d01c60d6010a2
274c8a06b48ec2492d48c13ab759d7932c38898c
8ce26e1e4be3d14b1b501257b7a949b012519ddf
0dd880abd96977235499665a6a8e55e708f767ed
74dc7cb556ac0815bc22ab05225e25b61c011415
c0f9b5f41e478ea2d1019adb6cb085c8ed2b490a
d1ba2845a2aa5ed2a88d1a9cb6d121eba0656764
9a9b953a9d7af81f0144b73331e6b8043ae954cc
7e9fb8e9fbe7bf46660e042a1fb631bccf3f95a8
5f68afbd016e4941a7d2b306938998b75d88ef42
879b42bd6f4d1d64879735dc8e1b6438dd4c24b3
d0a9046c80eb07529bf6e9696d8e8a557bb4e434
66bc141ddfb467854591e1b2beb812900ce66cef
38740ceea809eae60706e08faf9da0e98b0b65f1
161324f57583f8993a15205ec697b7aa38496d71
bd5c67555816623e1946b4539168af6591609d42
37ce01d6ed2b90d728a16131d7b982159d580052
0ffe593bdabf8ab15e8419b8f2ea1c62d768fd86
fc3f035e368907e750ac1fe33ad6eaf912d9de3a
Comment 4 Samba QA Contact 2022-08-16 20:19:16 UTC 
This bug was referenced in samba v4-17-stable (Release samba-4.17.0rc2):

496b9b45c385d5b89a1d335f157d73824db47004
33d00d7e8819b70861294bbc90726e0306443adb
deb009404a5e6ec6499b3df5aec94ff34675d063
c940c9eae9487840b077742a793d3631b2b8f027
8d09dc1691250e88d3bf11ea2a51b40d0dce8373
8031584e1eb776bafe3f29efbebadfa9bd2666fb
3a944329c31ac665940c3122547d01c60d6010a2
274c8a06b48ec2492d48c13ab759d7932c38898c
8ce26e1e4be3d14b1b501257b7a949b012519ddf
0dd880abd96977235499665a6a8e55e708f767ed
74dc7cb556ac0815bc22ab05225e25b61c011415
c0f9b5f41e478ea2d1019adb6cb085c8ed2b490a
d1ba2845a2aa5ed2a88d1a9cb6d121eba0656764
9a9b953a9d7af81f0144b73331e6b8043ae954cc
7e9fb8e9fbe7bf46660e042a1fb631bccf3f95a8
5f68afbd016e4941a7d2b306938998b75d88ef42
879b42bd6f4d1d64879735dc8e1b6438dd4c24b3
d0a9046c80eb07529bf6e9696d8e8a557bb4e434
66bc141ddfb467854591e1b2beb812900ce66cef
38740ceea809eae60706e08faf9da0e98b0b65f1
161324f57583f8993a15205ec697b7aa38496d71
bd5c67555816623e1946b4539168af6591609d42
37ce01d6ed2b90d728a16131d7b982159d580052
0ffe593bdabf8ab15e8419b8f2ea1c62d768fd86
fc3f035e368907e750ac1fe33ad6eaf912d9de3a
Comment 5 Ralph Böhme 2022-08-22 07:49:59 UTC 
Reassigning to Jule for inclusion in 4.17.
Comment 6 Ralph Böhme 2022-08-23 07:13:12 UTC 
Huh, looks like this was already pushed, just my +1 was missing on the backport.