Bug 15071 - waf produces incorrect names for python extensions with Python 3.11
Summary: waf produces incorrect names for python extensions with Python 3.11
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.16.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Stefan Metzmacher
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-19 06:12 UTC by Andreas Schneider
Modified: 2022-06-28 06:52 UTC (History)
3 users (show)

See Also:

Attachments
patch for 4.16 (38.88 KB, patch)
2022-05-23 11:28 UTC, Andreas Schneider 		metze: review+
Details
patch for 4.15 (62.07 KB, patch)
2022-05-23 11:41 UTC, Andreas Schneider 		metze: review+
asn: ci-passed+
Details
ldb-2.3.4 for 4.15 (23.43 KB, patch)
2022-06-09 04:54 UTC, Stefan Metzmacher 		asn: review+
Details
ldb-2.5.1 for 4.16 (23.43 KB, patch)
2022-06-09 04:55 UTC, Stefan Metzmacher 		asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2022-05-19 06:12:43 UTC 
Example:

install /builddir/build/BUILDROOT/libtdb-1.4.6-1.fc36.x86_64/usr/lib64/python3.10/site-packages/tdb.cpython-310-x86_64-linux-gnu.so (from bin/default/pytdb.cpython-310-x86_64-linux-gnu.so)

With

install /builddir/build/BUILDROOT/libtdb-1.4.6-1.fc37.x86_64/usr/lib64/python3.11/site-packages/tdb (from bin/default/pytdb)


In 3.10: map_shlib_extension() maps tdb.so to tdb.cpython-310-x86_64-linux-gnu.so

In 3.11: map_shlib_extension() maps it to tdb


https://gitlab.com/ita1024/waf/-/issues/2386
https://gitlab.com/ita1024/waf/-/merge_requests/2341


A new waf version should be released next week to address the issue. We will also have to do new libt* and libldb releases with the fix ...
Comment 1 Samba QA Contact 2022-05-23 09:35:04 UTC 
This bug was referenced in samba master:

d19dfe1efb2f6cb0dcf0a63b957df584d8ed5945
Comment 2 Andreas Schneider 2022-05-23 11:28:46 UTC 
Created attachment 17295 [details]
patch for 4.16
Comment 3 Stefan Metzmacher 2022-05-23 11:35:22 UTC 
Comment on attachment 17295 [details]
patch for 4.16

Looks good for 4.16, but don't we want to fix 4.15 too?
Comment 4 Andreas Schneider 2022-05-23 11:41:44 UTC 
Created attachment 17297 [details]
patch for 4.15
Comment 5 Stefan Metzmacher 2022-05-23 12:30:09 UTC 
Comment on attachment 17297 [details]
patch for 4.15

Can you run a 4.15 pipeline please and add ci-passed+, before finally signing it to Jule...
Comment 6 Andreas Schneider 2022-05-24 09:20:22 UTC 
Comment on attachment 17297 [details]
patch for 4.15

https://gitlab.com/samba-team/devel/samba/-/pipelines/545834038
Comment 7 Andreas Schneider 2022-05-25 06:32:24 UTC 
Jule, can you please apply the patches to the related branches? Thanks!
Comment 8 Jule Anger 2022-05-30 07:10:25 UTC 
Pushed to autobuild-v4-{16,15}-test.
Comment 9 Samba QA Contact 2022-05-30 09:11:04 UTC 
This bug was referenced in samba v4-16-test:

b09a37cd821afcc8acf4a6e71d13dadf7ffb1d0a
Comment 10 Samba QA Contact 2022-05-30 10:12:12 UTC 
This bug was referenced in samba v4-15-test:

5a4e0a40b424061c1e87028a591dd09578516311
Comment 11 Jule Anger 2022-05-30 10:40:56 UTC 
Closing out bug report.

Thanks!
Comment 12 Samba QA Contact 2022-06-08 17:58:04 UTC 
This bug was referenced in samba master:

0189ccf9fc3d2a77cc83cffe180e307bcdccebb4
53692735c733d01acbd953641f831a1f5e0cf6c5
27ceb1c3ad786386e746a5e2968780d791393b9e
Comment 13 Stefan Metzmacher 2022-06-09 04:54:45 UTC 
Created attachment 17331 [details]
ldb-2.3.4 for 4.15
Comment 14 Stefan Metzmacher 2022-06-09 04:55:53 UTC 
Created attachment 17332 [details]
ldb-2.5.1 for 4.16
Comment 15 Samba QA Contact 2022-06-09 12:15:03 UTC 
This bug was referenced in samba v4-16-test:

56eca407415dd7c69cde7e66f02f0c95d419721a
Comment 16 Samba QA Contact 2022-06-09 15:03:02 UTC 
This bug was referenced in samba v4-15-test:

604f94704f30e90ef960aa2be62a14d2e614a002
Comment 17 Samba QA Contact 2022-06-13 06:56:42 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.2):

b09a37cd821afcc8acf4a6e71d13dadf7ffb1d0a
56eca407415dd7c69cde7e66f02f0c95d419721a
Comment 18 Samba QA Contact 2022-06-28 06:52:08 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.8):

5a4e0a40b424061c1e87028a591dd09578516311
604f94704f30e90ef960aa2be62a14d2e614a002