Bug 15041 - username map - samba erroneously applies unix group memberships to user account entries
Summary: username map - samba erroneously applies unix group memberships to user accou...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.16.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-06 08:20 UTC by Pavel Filipenský
Modified: 2022-05-02 09:48 UTC (History)
3 users (show)

See Also:

Attachments
patch for 4.15 (12.05 KB, patch)
2022-04-07 17:06 UTC, Pavel Filipenský 		jra: review+
npower: review+
asn: review+
Details
patch for v4-16 (12.05 KB, patch)
2022-04-07 17:08 UTC, Pavel Filipenský 		jra: review+
npower: review+
asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Filipenský 2022-04-06 08:20:18 UTC 
Since a recent Samba upgrade (4.14 / 4.15 ?), unix group membership rules are erroneously applied to username map unix user accounts (i.e. entries without the '@' prefix).

This is a regression of commit from 04/2021:
    edda7a329e5bed442418de9782cec9f567092aae

    s3:smbd: Remove NIS support


Fix will follow.
Comment 1 Samba QA Contact 2022-04-07 09:50:03 UTC 
This bug was referenced in samba master:

1b0146182224fe01ed70815364656a626038685a
26e4268d6e3bde74520e36f3ca3cc9d979292d1d
0feeb6d58a6d6b1949faa842473053af4562c979
af8747a28bd62937a01fa4648f404bd0b09a44c0
6dc463d3e2eb229df1c4f620cfcaf22ac71738d4
Comment 2 Pavel Filipenský 2022-04-07 17:06:17 UTC 
Created attachment 17265 [details]
patch for 4.15
Comment 3 Pavel Filipenský 2022-04-07 17:08:08 UTC 
Created attachment 17266 [details]
patch for v4-16
Comment 4 Noel Power 2022-04-08 09:57:00 UTC 
reassign to Jule for inclusion in 4.15, 4.16. fyi: I am not sure what the rule is for a backport from a non-team member (which is the case here) regarding reviewers.
I think 1 reviewer should be sufficient (especially in the case of a trivial backport, like this one)
Comment 5 Jeremy Allison 2022-04-08 16:50:58 UTC 
Yeah, I thought one Team member would be enough for this one, but that's not the rule so... Maybe we should just add Pavel :-).
Comment 6 Jule Anger 2022-04-11 07:50:14 UTC 
Pushed to autobuild-v4-{16,15}-test.
Comment 7 Samba QA Contact 2022-04-11 08:51:12 UTC 
This bug was referenced in samba v4-16-test:

f09dfc53fd5eb4550ae1d0c574423e94e3f1f9bd
16038d75b2c554f2a63e06cabd9276c771783bbd
2b9d29ceb8a9c7da0d25f8a470fff574aa66e609
5e59bd41a8cce710bee8199951dd30b1792ec7b7
ef77abc2c4903b62da501dddc1e9e0c75b979899
Comment 8 Samba QA Contact 2022-04-11 09:22:04 UTC 
This bug was referenced in samba v4-15-test:

94bed5330dfc89debdcb84082fa70d87c3a5a484
77370c9954251c77336328e4bbf1da28639c4afd
fc3c13d67f4cab1b32aa764ee5735fba2378b4cb
26a7e8fa7a36820ce8cda66998f0a4b6aadd2296
799aa4e8892dacf1f760cc5f8f911a742f2d8034
Comment 9 Jule Anger 2022-04-11 11:20:03 UTC 
Closing out bug report.

Thanks!
Comment 10 Samba QA Contact 2022-04-26 14:45:02 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.7):

94bed5330dfc89debdcb84082fa70d87c3a5a484
77370c9954251c77336328e4bbf1da28639c4afd
fc3c13d67f4cab1b32aa764ee5735fba2378b4cb
26a7e8fa7a36820ce8cda66998f0a4b6aadd2296
799aa4e8892dacf1f760cc5f8f911a742f2d8034
Comment 11 Samba QA Contact 2022-05-02 09:48:31 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.1):

f09dfc53fd5eb4550ae1d0c574423e94e3f1f9bd
16038d75b2c554f2a63e06cabd9276c771783bbd
2b9d29ceb8a9c7da0d25f8a470fff574aa66e609
5e59bd41a8cce710bee8199951dd30b1792ec7b7
ef77abc2c4903b62da501dddc1e9e0c75b979899