Bug 15016 - Regression: create krb5 conf = yes doesn't work with a single KDC
Summary: Regression: create krb5 conf = yes doesn't work with a single KDC
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 4.15.5
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL: https://gitlab.com/samba-team/samba/-...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-15 12:17 UTC by Andreas Schneider
Modified: 2022-04-26 14:45 UTC (History)
3 users (show)

See Also:


Attachments
patch for 4.16 (14.82 KB, patch)
2022-03-16 14:49 UTC, Andreas Schneider
gd: review+
metze: review+
Details
patch for 4.15 (14.82 KB, patch)
2022-03-16 14:50 UTC, Andreas Schneider
gd: review+
metze: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2022-03-15 12:17:54 UTC
If we only have a single KDC ip address which create_local_private_krb5_conf_for_domain() passes to get_kdc_ip_string(), it always returns NULL instead of the IP string we created.
Comment 1 Andreas Schneider 2022-03-15 16:17:46 UTC
Patch will follow.
Comment 2 Samba QA Contact 2022-03-16 14:27:04 UTC
This bug was referenced in samba master:

d2ac90cdd5672330ed9c323fc474f8ba62750a6f
567b1996796e5d3cf572653f38817d832fa135ca
313f03c78487ae49747b8143220ecbfe8ad9310a
7f721dc2eee0064a1ddd480fcaf77bf1659c7a26
812032833aa65729dbbfd4313a6e3fe072c88530
652c8ce1672dfead00c7af6af22e3bb3927764ec
cca189d0934790418e27d9d01282370b1e6a057f
12c843ad0a97fcbaaea738b82941533e5d2aec99
68d181ee676e17a5cdcfc12c5cc7eef242fdfa6c
Comment 3 Andreas Schneider 2022-03-16 14:49:27 UTC
Created attachment 17216 [details]
patch for 4.16
Comment 4 Andreas Schneider 2022-03-16 14:50:33 UTC
Created attachment 17217 [details]
patch for 4.15
Comment 5 Guenther Deschner 2022-03-17 09:28:47 UTC
Comment on attachment 17216 [details]
patch for 4.16

LGTM
Comment 6 Guenther Deschner 2022-03-17 09:30:19 UTC
Jule, please add to 4.15 and 4.16, thanks!
Comment 7 Jule Anger 2022-03-17 10:13:28 UTC
Pushed to autobuild-v4-{16,15}-test.
Comment 8 Samba QA Contact 2022-03-17 10:25:16 UTC
This bug was referenced in samba v4-16-test:

dd6c50b82ee7e1ffc4f4a481543b4888df37b89c
c20ca210fb8cb123501cfa9ead0fbb2dd29acdf0
2599f5313bd86b9821ba38dd0b9679b5aaa50acc
cce13c772f1db5a03e43f083819c458a4a8844c8
cfbd47d7b48896847cd43da58167cd6afcbef31e
3c98408be7ddfe1d3df45b4790746eb608c2b98d
3c5d0c379d7882d8c3c45a0dde53a68c7ec8a2a7
abe01ca6b215e51dea8328869731d88956bfb2dc
9272ec1a2452ecea60b894f649c18d870cf9e2aa
Comment 9 Samba QA Contact 2022-03-17 10:55:17 UTC
This bug was referenced in samba v4-15-test:

12c58adffe4b364208a510a10181daace91638bf
fd2373c6bcf3f2128532cec8868c876569fc13ab
5608804f02d1af530fd2b70537da1904168a3bec
1f7b6fc56c51958af02a2370fe857995bfa5fd10
a76c64f86d80c465d54bae60943fc6dd53e61f34
3016f01d0c4b4d2845d8b921070b18ed03f4e917
9319309ac1adf42765e9f3bf325000b92585cd3e
736df42fdf9b4f7977eb6857ff3ab91a5df62b65
9d91942913e0481cfb4af80eeb5a316f6c9d2c3f
Comment 10 Jule Anger 2022-03-17 11:05:32 UTC
Closing out bug report.

Thanks!
Comment 11 Samba QA Contact 2022-03-21 12:18:34 UTC
This bug was referenced in samba v4-16-stable (Release samba-4.16.0):

dd6c50b82ee7e1ffc4f4a481543b4888df37b89c
c20ca210fb8cb123501cfa9ead0fbb2dd29acdf0
2599f5313bd86b9821ba38dd0b9679b5aaa50acc
cce13c772f1db5a03e43f083819c458a4a8844c8
cfbd47d7b48896847cd43da58167cd6afcbef31e
3c98408be7ddfe1d3df45b4790746eb608c2b98d
3c5d0c379d7882d8c3c45a0dde53a68c7ec8a2a7
abe01ca6b215e51dea8328869731d88956bfb2dc
9272ec1a2452ecea60b894f649c18d870cf9e2aa
Comment 12 Samba QA Contact 2022-04-26 14:45:14 UTC
This bug was referenced in samba v4-15-stable (Release samba-4.15.7):

12c58adffe4b364208a510a10181daace91638bf
fd2373c6bcf3f2128532cec8868c876569fc13ab
5608804f02d1af530fd2b70537da1904168a3bec
1f7b6fc56c51958af02a2370fe857995bfa5fd10
a76c64f86d80c465d54bae60943fc6dd53e61f34
3016f01d0c4b4d2845d8b921070b18ed03f4e917
9319309ac1adf42765e9f3bf325000b92585cd3e
736df42fdf9b4f7977eb6857ff3ab91a5df62b65
9d91942913e0481cfb4af80eeb5a316f6c9d2c3f