Bug 14995 - Use Heimdal 8.0 (pre) rather than an earlier snapshot
Summary: Use Heimdal 8.0 (pre) rather than an earlier snapshot
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.16.0rc3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-01 08:46 UTC by Andrew Bartlett
Modified: 2022-04-04 12:50 UTC (History)
3 users (show)

See Also:


Attachments
Patches for v4-16-test (1.43 MB, patch)
2022-03-02 08:08 UTC, Stefan Metzmacher
abartlet: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2022-03-01 08:46:18 UTC
Since the Heimdal snapshot taken and imported just before Samba 4.16.0rc0 upstream Heimdal has fixed a number of issues including:
 * addressing compiler warnings
 * avoiding undefined behaviour (pointers going invalid via (essentially) ptr[-1]+1). 

Upstream has also significantly reworked the HDB and KDC APIs with the hope that these might now be long-term stable. 

It could rightly be seen as an abuse to import a new Heimdal in at this point, and it could well be argued that this is way too late, and a great candidate patch set for Samba 4.17. 

However, along with death and taxes, the other certainty in this life is more security releases, and by using a release closer to Heimdal 8.0 we are more likely to be able to just apply the patches.  

Likewise when backporting, we will only have to target the old HDB and KDC API used in Samba 4.0 - 4.15 and the new upstream API from Heimdal 8.0, and not a third muddle in the middle.
Comment 1 Samba QA Contact 2022-03-01 18:08:03 UTC
This bug was referenced in samba master:

f6fe86924c2ca756083d3628d5dbace0b12d06b0
ef95fb439237910b945b8d6a3ad4a140a8d6d1ea
6d8fec7006e8eadf5967a6f2f5add7d3c2c7bd3e
9936038fae72fb440864be543e9afd500444d502
9eb27f296ae2b797803fffbb7f4cb34d8eb06f34
Comment 2 Samba QA Contact 2022-03-01 23:29:04 UTC
This bug was referenced in samba master:

fccf9859786dfb50b317ea2296c2494997f0ae09
51569b3152a952d07fddaa3a70d60c920618c704
f2ca9c5db7e1bb20cfc6705633b48c32b1496334
a2f7987d58372cfc52bc5f9786c0719439956fee
7989ef0aa7b75b2e5af7be445fc64cbf49b2985c
0d37a1928100e229bea46701b41d4efa72e10266
a5799cea037a4613ba4d1073fff6e6151ed06c76
83586e8f5846fff7a8bbe47e743e03166b559584
f234361abea4166ce4e10cfa4e7f4096b83480a9
b9f4ea8bdb70476d6cc6df962bf6b28805588ed5
675f913e54d8fddb9173c1e67b9d14885cc1d878
7cb68fdba75c362cdfd8f3bf08bcd9c22bbe4556
068f2bf117ab9968011fdb8d60b98bb37d529658
94d387abd5031c12989f925ee5eb733432402d1d
9399a15fabb5a1b8470b1069a098132e2fdb7f0f
c9b0b4bfc4e2e0b08b21f39bf56fd5395d66d66f
791be84c3eecb95e03611458e2305bae272ba267
Comment 3 Stefan Metzmacher 2022-03-02 08:08:43 UTC
Created attachment 17181 [details]
Patches for v4-16-test
Comment 4 Andrew Bartlett 2022-03-02 10:10:25 UTC
Comment on attachment 17181 [details]
Patches for v4-16-test

Yeah, why not!  :-)

Thanks so much for all your help, this should make 4.16 maintenance much more practical.
Comment 5 Andrew Bartlett 2022-03-02 10:11:21 UTC
Assigning to Jule for another RC before 4.16.0 final.

We still need some WHATSNEW text for this!
Comment 6 Jule Anger 2022-03-02 10:17:40 UTC
Pushed to autobuild-v4-16-test.
Comment 7 Samba QA Contact 2022-03-02 11:14:04 UTC
This bug was referenced in samba v4-14-test:

c2a3c17da9ffb90afa09fe7b881ed1859c35481c
Comment 8 Samba QA Contact 2022-03-02 11:25:24 UTC
This bug was referenced in samba v4-16-test:

b668c076722745c060ba7b1c5e4b2c9342452fe2
635c8b730f7163dcb7e73d640948d91f88e70369
77ed10e2ff82a2c3df873c0fee4de586e4a82d49
97011aa3ce11877685a735906b868d1789a089d7
947ad1581a6bdc6695a63e7af477f65564a46fda
c9a77ff43e07c144052e9db53699ab3304233ac0
e26fbf420e41666cb1ccbe955a411ffbbcdfaae4
26880578a5f8bc2fc3944ab08817b14d023a98b1
9627ee616b55d809d1b31cb2c2cbbd46afbd3acb
115d8e493fe36cc08e1f20b6fae4f73f9da959b2
cef9e6f8514c2bddd20d15d03b81825b6a09416b
b88d892498077a94ac81b6d554923ff7b50b8667
9e76300526621fa616b88e16b10b1a55f56923b3
b6e2028f277651588385002a59f139dd714b16e6
0918e692fac217c44b1de8aec331765b251b468d
5493c1a5df62249d11c14ad2c5321d8c3f74060d
8ae5ce46e57e8a78d55f3bd6cbb679ca8308adeb
f90e729e01eb9d43345bde12af891acf5d8ab64b
12a61bb7416eed3b7fa261791eea926f683ee5f1
71912b630e945ab554d2f36f94d879c4ec87cfb9
794c717ba75c15e96bdc3a651ddd0715bcd4f92e
5b6ca18e020416aef105fa13d2e35bbd03c4da45
Comment 9 Samba QA Contact 2022-03-02 12:28:05 UTC
This bug was referenced in samba v4-15-test:

e19d287cef39d137124295331243c019bd56438f
Comment 10 Jule Anger 2022-03-02 15:30:12 UTC
(In reply to Andrew Bartlett from comment #5)
Reassigning to Andrew for the WHATSNEW changes.
Comment 11 Samba QA Contact 2022-03-08 15:25:50 UTC
This bug was referenced in samba v4-16-stable (Release samba-4.16.0rc5):

b668c076722745c060ba7b1c5e4b2c9342452fe2
635c8b730f7163dcb7e73d640948d91f88e70369
77ed10e2ff82a2c3df873c0fee4de586e4a82d49
97011aa3ce11877685a735906b868d1789a089d7
947ad1581a6bdc6695a63e7af477f65564a46fda
c9a77ff43e07c144052e9db53699ab3304233ac0
e26fbf420e41666cb1ccbe955a411ffbbcdfaae4
26880578a5f8bc2fc3944ab08817b14d023a98b1
9627ee616b55d809d1b31cb2c2cbbd46afbd3acb
115d8e493fe36cc08e1f20b6fae4f73f9da959b2
cef9e6f8514c2bddd20d15d03b81825b6a09416b
b88d892498077a94ac81b6d554923ff7b50b8667
9e76300526621fa616b88e16b10b1a55f56923b3
b6e2028f277651588385002a59f139dd714b16e6
0918e692fac217c44b1de8aec331765b251b468d
5493c1a5df62249d11c14ad2c5321d8c3f74060d
8ae5ce46e57e8a78d55f3bd6cbb679ca8308adeb
f90e729e01eb9d43345bde12af891acf5d8ab64b
12a61bb7416eed3b7fa261791eea926f683ee5f1
71912b630e945ab554d2f36f94d879c4ec87cfb9
794c717ba75c15e96bdc3a651ddd0715bcd4f92e
5b6ca18e020416aef105fa13d2e35bbd03c4da45
Comment 12 Samba QA Contact 2022-03-15 13:25:45 UTC
This bug was referenced in samba v4-15-stable (Release samba-4.15.6):

e19d287cef39d137124295331243c019bd56438f
Comment 13 Samba QA Contact 2022-04-04 12:50:20 UTC
This bug was referenced in samba v4-14-stable (Release samba-4.14.13):

c2a3c17da9ffb90afa09fe7b881ed1859c35481c