Bug 14956 - ndr_push_string() adds implicit termination for STR_NOTERM|REMAINING empty strings
Summary: ndr_push_string() adds implicit termination for STR_NOTERM|REMAINING empty st...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: DCE-RPCs and pipes (show other bugs)
Version: 4.15.4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-21 23:35 UTC by Stefan Metzmacher
Modified: 2022-04-04 12:49 UTC (History)
2 users (show)

See Also:

Attachments
Patches for v4-16-test (80.87 KB, patch)
2022-01-24 16:49 UTC, Stefan Metzmacher 		asn: review+
Details
Patches for v4-15-test (80.87 KB, patch)
2022-01-24 16:50 UTC, Stefan Metzmacher 		asn: review+
Details
Patches for v4-14-test (80.86 KB, patch)
2022-01-24 16:51 UTC, Stefan Metzmacher 		asn: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2022-01-21 23:35:25 UTC 
we expand empty strings without termination to an empty string with termination
byte(s)
Comment 1 Samba QA Contact 2022-01-24 16:19:03 UTC 
This bug was referenced in samba master:

58b09e107cadd7fb8191822d4e7e42657b1ed4c7
9110a8854a518befa2908c26076e17a085c5ec48
b489b7feda19b3c0f0fe2300f2c76d416776355b
d1a7f392a8ceef111a5d6c3d2a3bdb9dcb90db5e
1dc385cb648f0c37b04f4ede6b1c96916e379b23
8da26cb6725b5d853ab481a348a3a672966715b5
43648e95a514020da4c7efa62df55d0882e3db85
12464bd4c222d996aac6d6250b7945d63f20f4bc
Comment 2 Stefan Metzmacher 2022-01-24 16:49:50 UTC 
Created attachment 17123 [details]
Patches for v4-16-test
Comment 3 Stefan Metzmacher 2022-01-24 16:50:35 UTC 
Created attachment 17124 [details]
Patches for v4-15-test
Comment 4 Stefan Metzmacher 2022-01-24 16:51:01 UTC 
Created attachment 17125 [details]
Patches for v4-14-test
Comment 5 Andreas Schneider 2022-01-28 11:36:28 UTC 
Jule, please apply the patches to the relevant branches. Thanks!
Comment 6 Jule Anger 2022-01-30 09:19:57 UTC 
Pushed to autobuild-v4-{16,15,14}-test.
Comment 7 Samba QA Contact 2022-01-30 10:25:12 UTC 
This bug was referenced in samba v4-14-test:

ec8b2ae38a99a0e914e9f5764ff881587546a655
7b844ab490c0093fee3e0baaae2f7d77043ee409
7b96fe7e12bbe509a0343b2fe50ea2c844864ce2
2f0a433811ac0021b6e4a443e016133eb1241d35
56ccaafb0322539d3e6cda40bc14aa9cad7a5884
1d7e27ffa68013d4bdf879b25f3d3570d1873326
0544a3a3c9c7e51c80428965a6f37cc486d2538d
96f88613a5e8279aebb734ba5b41a474ff5f5db1
Comment 8 Samba QA Contact 2022-01-30 11:25:21 UTC 
This bug was referenced in samba v4-15-test:

85c3f4ad396b5c0bc2923c3e4dc8a91e0bb8cf7f
4a6c8349c39eda9fa39ee3e7eb33ace37d391bad
205ebe243895ed3f64b50887f00ca418134e17d8
318266fcedb1ddd20725e92207e681a31bd6537b
3fcc39542dabcced640f25898fe6e96f8d6fa735
cb7e6f0e7fbaa944412d167adbe06fb6057cb370
c0795f1a6348048c849b853c5c6e0cbc7b002daa
bab52ff3bf88cfbacead33d6a09e851f48c81004
Comment 9 Samba QA Contact 2022-01-30 11:53:03 UTC 
This bug was referenced in samba v4-16-test:

8097c9b388531483e47defb0d5ebe31fb4cecc51
f1cbfdc43c8e940c6d2667eccc7545e39be49468
1538a574a22c2762ed322ffbf34f63ca872f034b
c1bd0f0d5e3cc6da66e9241832ae29048c4cda40
a55de23fb057d1bf431f20225529e2eadbbccfdf
9be924f907c5215d9452db1cb407c83f39df67a5
7734584c4fd5bee49ed564771a16d63f2b005937
4d3054261df3b8726a4db943b0734071ad151423
Comment 10 Jule Anger 2022-01-30 12:56:18 UTC 
Closing out bug report.

Thanks!
Comment 11 Samba QA Contact 2022-01-31 17:25:22 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.0rc2):

8097c9b388531483e47defb0d5ebe31fb4cecc51
f1cbfdc43c8e940c6d2667eccc7545e39be49468
1538a574a22c2762ed322ffbf34f63ca872f034b
c1bd0f0d5e3cc6da66e9241832ae29048c4cda40
a55de23fb057d1bf431f20225529e2eadbbccfdf
9be924f907c5215d9452db1cb407c83f39df67a5
7734584c4fd5bee49ed564771a16d63f2b005937
4d3054261df3b8726a4db943b0734071ad151423
Comment 12 Samba QA Contact 2022-03-15 13:26:56 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.6):

85c3f4ad396b5c0bc2923c3e4dc8a91e0bb8cf7f
4a6c8349c39eda9fa39ee3e7eb33ace37d391bad
205ebe243895ed3f64b50887f00ca418134e17d8
318266fcedb1ddd20725e92207e681a31bd6537b
3fcc39542dabcced640f25898fe6e96f8d6fa735
cb7e6f0e7fbaa944412d167adbe06fb6057cb370
c0795f1a6348048c849b853c5c6e0cbc7b002daa
bab52ff3bf88cfbacead33d6a09e851f48c81004
Comment 13 Samba QA Contact 2022-04-04 12:49:22 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.13):

ec8b2ae38a99a0e914e9f5764ff881587546a655
7b844ab490c0093fee3e0baaae2f7d77043ee409
7b96fe7e12bbe509a0343b2fe50ea2c844864ce2
2f0a433811ac0021b6e4a443e016133eb1241d35
56ccaafb0322539d3e6cda40bc14aa9cad7a5884
1d7e27ffa68013d4bdf879b25f3d3570d1873326
0544a3a3c9c7e51c80428965a6f37cc486d2538d
96f88613a5e8279aebb734ba5b41a474ff5f5db1