Bug 14855 - SMB3 cancel requests should only include the MID together with AsyncID when AES-128-GMAC is used
Summary: SMB3 cancel requests should only include the MID together with AsyncID when A...
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 4.15.0
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
: 14858 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-04 11:04 UTC by Stefan Metzmacher
Modified: 2021-10-27 13:01 UTC (History)
3 users (show)

See Also:

Attachments
Patch for v4-15-test (2.30 KB, patch)
2021-10-19 20:28 UTC, Stefan Metzmacher 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2021-10-04 11:04:02 UTC 
In order to let the server check the SMB signing on SMB2 Cancel PDUs when AES-128-GMAC was negotiated, it's required that the client always includes the MID value, even if the AsyncID is also included.

But it turns out that some vendors (which don't support AES-128-GMAC yet)
require the MID of an SMB2 Cancel to be 0 is the AsyncID is also provided.

In order to maintain support for such servers, we should send the MID
only if AES-128-GMAC (or any future algorithm) is used.
Comment 1 Samba QA Contact 2021-10-19 19:24:04 UTC 
This bug was referenced in samba master:

dd07bb81bb9a570b321bb2e5adab42546736ff9f
Comment 2 Stefan Metzmacher 2021-10-19 20:28:46 UTC 
Created attachment 16856 [details]
Patch for v4-15-test
Comment 3 Jeremy Allison 2021-10-19 20:44:40 UTC 
Re-assigning to Jule for inclusion in 4.15.next.
Comment 4 Jeremy Allison 2021-10-21 15:55:49 UTC 
*** Bug 14858 has been marked as a duplicate of this bug. ***
Comment 5 Samba QA Contact 2021-10-22 08:55:38 UTC 
This bug was referenced in samba v4-15-test:

cb768d624eb4e9e4bbaec5e1408d59267c5bb475
Comment 6 Jule Anger 2021-10-22 09:08:53 UTC 
Closing out bug report.

Thanks!
Comment 7 Samba QA Contact 2021-10-27 13:01:53 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.1):

cb768d624eb4e9e4bbaec5e1408d59267c5bb475