Bug 14831 - share and server swapped in smbget password prompt
Summary: share and server swapped in smbget password prompt
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 minor (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-13 11:55 UTC by Dennis
Modified: 2022-05-02 09:47 UTC (History)
4 users (show)

See Also:

Attachments
Patch which should solve this (404 bytes, patch)
2021-09-13 11:55 UTC, Dennis 		no flags Details
git-am fix for 4.16.next, 4.15.next. (1012 bytes, patch)
2022-04-06 20:41 UTC, Jeremy Allison 		asn: review+
npower: review+
jra: review? (dmulder)
 Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis 2021-09-13 11:55:24 UTC 
Created attachment 16806 [details]
Patch which should solve this

When running smbget the server and share are mixed up in the password prompt:

% smbget -Ru -w mydomain -U myusername smb://server1/share1/folder
Password for [myusername] connecting to //share1/server1:

I've added a patch which should fix this.
Comment 1 Jeremy Allison 2022-01-13 23:04:57 UTC 
Thanks Dennis. Can you send in the Samba Developers Declaration as described here:

https://www.samba.org/samba/devel/copyright-policy.html

and I'll try and get this merged for 4.15.next.
Comment 2 Samba QA Contact 2022-04-06 17:10:04 UTC 
This bug was referenced in samba master:

f1765f91b015d64122e74c01c7c6d0984cc7af87
Comment 3 Jeremy Allison 2022-04-06 20:41:17 UTC 
Created attachment 17264 [details]
git-am fix for 4.16.next, 4.15.next.

Cherry-picked from master.
Comment 4 Noel Power 2022-04-11 08:49:53 UTC 
Comment on attachment 17264 [details]
git-am fix for 4.16.next, 4.15.next.

lgtm (I guess we need another reviewer right?)
Comment 5 Jeremy Allison 2022-04-11 16:26:51 UTC 
(In reply to Noel Power from comment #4)

No, two is good enough.
Comment 6 Jeremy Allison 2022-04-11 16:27:15 UTC 
Re-assigning to Jule for inclusion in 4.15.next, 4.16.next.
Comment 7 Jule Anger 2022-04-15 13:02:25 UTC 
Pushed to autobuild-v4-{16,15}-test.
Comment 8 Samba QA Contact 2022-04-15 14:04:04 UTC 
This bug was referenced in samba v4-15-test:

ef96b255edcf0f4e398ca6617830c2affcc1642b
Comment 9 Samba QA Contact 2022-04-15 14:46:03 UTC 
This bug was referenced in samba v4-16-test:

41a2825ea5790296359aa069e19a55da7bf64be0
Comment 10 Jule Anger 2022-04-15 16:58:29 UTC 
Closing out bug report.

Thanks!
Comment 11 Dennis 2022-04-19 11:29:23 UTC 
Thanks for fixing this.
Comment 12 Samba QA Contact 2022-04-26 14:44:17 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.7):

ef96b255edcf0f4e398ca6617830c2affcc1642b
Comment 13 Samba QA Contact 2022-05-02 09:47:26 UTC 
This bug was referenced in samba v4-16-stable (Release samba-4.16.1):

41a2825ea5790296359aa069e19a55da7bf64be0