Created attachment 16773 [details]
Add missing 'nsl' build settings via function check
After running configure on a sunos5+ setup, legacy_quota_libs = 'nsl' is set in bin/c4che/default_cache.py by s3/wscript.
Next, running make gives the following build error:
Checking project rules ...
Unknown dependency 'nsl' in 'smbd_base.objlist'
This is because other settings are missed: TARGET_TYPE['nsl'], LIB_NSL, LIB_nsl, CLAGS_nsl, LDFLAGS_nsl, etc.
The attached patch checks for the utilized function 'clnt_call' in libnsl, which adds these. The build is able to start now.
The build succeeds in the 4.14 line as s3/rpcclient/wscript_build always runs conf.CHECK_FUNCS_IN('yp_get_default_domain', 'nsl') which adds in the extra dependencies. But this patch could be added there too if desired.
Any chance you could submit a MR per https://wiki.samba.org/index.php/Contribute
If you let me know your gitlab username I can help you jump to
https://wiki.samba.org/index.php/Contribute#Subsequent_Merge_Requests_.28and_complex_first_requests.29 (but you still need to read the rest).
in your commit message in particular.
I know this is really simple but it still helps.
Sadly, per https://wiki.samba.org/index.php/Contribute#Bugzilla patches here are easier to loose track of and don't get you CI feedback, so we really appreciate it if you can submit via Gitlab.