The change to record the remote LDB address means that the implicit cache of the sam.ldb ldb context is not used.
This is because otherwise the wrong address would be stored.
During the LSA LookupSids3 call (which is for SCHANNEL only and has no handles or long-term context) a new sam.ldb handle is created, and then lost at the end of the call. The SAMDB connection cost is high, and we should cache this if possible.
We should find a long-term implicit context for the authenticated session to put the sam.ldb on, and save that connection cost, as well as making the caching explicit.
Inadvertently introduced in:
Author: Gary Lockyer <firstname.lastname@example.org>
Date: Thu Apr 12 06:41:30 2018 +1200
samdb: Add remote address to connect
Signed-off-by: Gary Lockyer <email@example.com>
Reviewed-by: Andrew Bartlett <firstname.lastname@example.org>
Made more noticeable by bug 14806
This bug was referenced in samba master:
This bug was referenced in samba v4-15-test:
This bug was referenced in samba v4-15-stable (Release samba-4.15.0rc6):
This bug was referenced in samba v4-13-test:
This bug was referenced in samba v4-14-test: