Bug 14793 - We should start the SMB encryption as soon as possible
Summary: We should start the SMB encryption as soon as possible
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 4.15.0rc2
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-11 15:32 UTC by Stefan Metzmacher
Modified: 2021-09-07 07:13 UTC (History)
2 users (show)

See Also:

Attachments
Patches for v4-15-test (7.07 KB, patch)
2021-08-12 07:53 UTC, Stefan Metzmacher 		jra: review+
Details
Patches for v4-14-test (7.07 KB, patch)
2021-08-12 07:55 UTC, Stefan Metzmacher 		jra: review+
Details
Patch for v4-13-test (only covers smbclient) (3.20 KB, patch)
2021-08-13 09:05 UTC, Stefan Metzmacher 		jra: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2021-08-11 15:32:04 UTC 
Currently we do the first IPC$ connection and the VALIDATE_NEGOTIATE without
encryption and only with signing.
Comment 1 Samba QA Contact 2021-08-11 23:04:04 UTC 
This bug was referenced in samba master:

21302649c46441ea325c66457294225ddb1d6235
289b7a1595ab13a200cfb327604e4b9296fa81e0
Comment 2 Stefan Metzmacher 2021-08-12 07:53:14 UTC 
Created attachment 16732 [details]
Patches for v4-15-test
Comment 3 Stefan Metzmacher 2021-08-12 07:55:09 UTC 
Created attachment 16733 [details]
Patches for v4-14-test
Comment 4 Jeremy Allison 2021-08-12 16:38:07 UTC 
Re-assigning to Jule for inclusion in 4.15.rcNext, 4.14.next.
Comment 5 Jule Anger 2021-08-13 06:40:15 UTC 
Pushed to autobuild-v4-{15,14}-test.
Comment 6 Samba QA Contact 2021-08-13 07:53:04 UTC 
This bug was referenced in samba v4-14-test:

f25d13156869133da6ead8b4f507ce129833f711
3d912fe86cfdb9f6d45645bf0122a814f79cb3a7
Comment 7 Samba QA Contact 2021-08-13 08:17:04 UTC 
This bug was referenced in samba v4-15-test:

9d152be356dc4bf48943a45f22591ab017f0ca1b
c5fbec5db03ecce53f4f15434de0b246cafffeff
Comment 8 Stefan Metzmacher 2021-08-13 09:05:42 UTC 
Created attachment 16734 [details]
Patch for v4-13-test (only covers smbclient)
Comment 9 Jeremy Allison 2021-08-13 17:38:04 UTC 
Re-assigning to Jule to add the 4-13 patch.
Comment 10 Samba QA Contact 2021-08-24 13:26:06 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.7):

f25d13156869133da6ead8b4f507ce129833f711
3d912fe86cfdb9f6d45645bf0122a814f79cb3a7
Comment 11 Jule Anger 2021-08-25 08:52:01 UTC 
Pushed to autobuild-v4-13-test.
Comment 12 Samba QA Contact 2021-08-26 09:25:44 UTC 
This bug was referenced in samba v4-15-stable (Release samba-4.15.0rc3):

9d152be356dc4bf48943a45f22591ab017f0ca1b
c5fbec5db03ecce53f4f15434de0b246cafffeff
Comment 13 Samba QA Contact 2021-08-26 10:49:03 UTC 
This bug was referenced in samba v4-13-test:

23ce76e94e80954cc6d6c6395ceefb65cf926b92
Comment 14 Jule Anger 2021-08-26 13:09:33 UTC 
Closing out bug report.

Thanks!
Comment 15 Samba QA Contact 2021-09-07 07:13:46 UTC 
This bug was referenced in samba v4-13-stable (Release samba-4.13.11):

23ce76e94e80954cc6d6c6395ceefb65cf926b92