Bug 14777 - Do not quote passed argument of configure script
Summary: Do not quote passed argument of configure script
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: Build (show other bugs)
Version: 4.14.4
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jule Anger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-02 15:48 UTC by Andreas Schneider
Modified: 2021-09-07 07:14 UTC (History)
3 users (show)

See Also:

Attachments
patch for 4.15, 4.14, 4.13 (880 bytes, patch)
2021-08-04 08:58 UTC, Andreas Schneider 		slow: review+
asn: ci-passed? (abartlet)
 Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schneider 2021-08-02 15:48:55 UTC 
Do not quote passed argument of configure script.

commit 6a63ab467f46542b81cc33ff7414602e5d38e813 (HEAD -> asn-fix-configure, gitlab/asn-fix-configure)
Author:     Andreas Schneider <asn@samba.org>
AuthorDate: Mon Aug 2 17:43:01 2021 +0200
Commit:     Andreas Schneider <asn@samba.org>
CommitDate: Mon Aug 2 17:45:50 2021 +0200

    configure: Do not put arguments into double quotes
    
    This could create an issue that arguments don't get split by python and then the
    following could happen:
    
        ./configure --libdir=/usr/lib64 --enable-clangdb
    
        LIBDIR='/usr/lib64 --enable-clangdb'
    
    This ends then up in parameters.all.xml:
    
        <!ENTITY pathconfig.LIBDIR   '/usr/lib64 --enable-clangdb'>
    
    The python parser then errors out:
    
        xml.etree.ElementTree.ParseError: not well-formed (invalid token)
Comment 1 Samba QA Contact 2021-08-03 18:37:03 UTC 
This bug was referenced in samba master:

e2962b4262fc4a7197a3fcbd010fcfaca781baea
Comment 2 Andreas Schneider 2021-08-04 08:58:41 UTC 
Created attachment 16713 [details]
patch for 4.15, 4.14, 4.13
Comment 3 Ralph Böhme 2021-08-06 16:25:33 UTC 
Reassigning to Jule for inclusion in 4.15, 4.14 and 4.13.
Comment 4 Jule Anger 2021-08-09 11:31:27 UTC 
Pushed to autobuild-v4-{15,14,13}-test.
Used: git cherry-pick -x e2962b4262fc4a7197a3fcbd010fcfaca781baea
Comment 5 Samba QA Contact 2021-08-09 12:06:07 UTC 
This bug was referenced in samba v4-15-test:

fccedb4d94abac9909c2ed00b07af6a207b09590
Comment 6 Samba QA Contact 2021-08-09 13:45:41 UTC 
This bug was referenced in samba v4-15-stable:

fccedb4d94abac9909c2ed00b07af6a207b09590
Comment 7 Samba QA Contact 2021-08-09 13:46:03 UTC 
This bug was referenced in samba v4-13-test:

aa64f02ca944be1a6e7baa552c602b005c8c7d86
Comment 8 Samba QA Contact 2021-08-10 12:42:12 UTC 
This bug was referenced in samba v4-14-test:

de50dc5c3db243c926b4c10e5355ed47f7b593af
Comment 9 Jule Anger 2021-08-11 07:43:18 UTC 
Closing out bug report.

Thanks!
Comment 10 Samba QA Contact 2021-08-24 13:12:41 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.7):

de50dc5c3db243c926b4c10e5355ed47f7b593af
Comment 11 Samba QA Contact 2021-09-07 07:14:12 UTC 
This bug was referenced in samba v4-13-stable (Release samba-4.13.11):

aa64f02ca944be1a6e7baa552c602b005c8c7d86