Bug 14749 - vfs_btrfs does unwanted read/write copy fallback for FSCTL_DUP_EXTENTS_TO_FILE
Summary: vfs_btrfs does unwanted read/write copy fallback for FSCTL_DUP_EXTENTS_TO_FILE
Status: RESOLVED WORKSFORME
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: unspecified
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Ralph Böhme
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-28 09:24 UTC by Ralph Böhme
Modified: 2021-07-28 14:07 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Böhme 2021-06-28 09:24:25 UTC 
It seems the behaviour to fail the FSCTL_DUP_EXTENTS_TO_FILE if the ioctl() failed was never really implemented.

Commit 373d3015bc7c42d8ab28e72cd76806cce1d9c78f probably should have checked VFS_COPY_CHUNK_FL_MUST_CLONE in vfs_btrfs.c, but it seems this was overlooked.

After changing the VFS API from copy-chunk to offload read/write the check is still missing from vfs_default offload-write implementation.
Comment 1 Ralph Böhme 2021-06-28 09:24:55 UTC 
Have patch, need bugnumber.