Have path, need bugnumber.
This bug was referenced in samba master: ac10058d7f6b4605157f508189a448310f5f18da 263c95aee38c9198ad9a30c4d960d72f46b7c27a
Created attachment 16662 [details] git-am fix for 4.14.next.
NB. I checked and POSIX-SYMLINK-SETPATHINFO run from master passes against 4.13, so this is something we only recently broke with the smb_fname->fsp changes I think (thank goodness). So we only need this for 4.14.next. Thanks Noel !
Comment on attachment 16662 [details] git-am fix for 4.14.next. Patch 1/2 is missing reviewed-by. Can we fix this at least for the backport?
Created attachment 16663 [details] git-am fix for 4.14.next. Updated with added RB. Sorry for missing that.
Reassigning to Karolin for inclusion in 4.14.
(In reply to Ralph Böhme from comment #7) Pushed to autobuild-v4-14-test.
Hi Jeremy, autobuild fails with: UNEXPECTED(failure): samba3.smbtorture_s3.crypt.POSIX-SYMLINK-SETPATHINFO.smbtorture(nt4_dc_smb1) REASON: Exception: Exception: using seed 1629117742 host=10.53.57.55 share=posix_share user=kseeger myname=lclnt4dc2smb1 Running POSIX-SYMLINK-SETPATHINFO Starting POSIX-SYMLINK-SETPATHINFO test cli_posix_open of file_setpath_real failed error NT_STATUS_ACCESS_DENIED TEST POSIX-SYMLINK-SETPATHINFO FAILED! Could you have a look, please? Thanks! Karolin
(In reply to Karolin Seeger from comment #9) make -j test TESTS=POSIX-SYMLINK-SETPATHINFO works here. Maybe autobuild was flaky? Can you please try it once again?
(In reply to Ralph Böhme from comment #10) Karolin responded off-bugzilla that she tried three more times and it failed each of them. I now also tried $ script/autobuild.py --testbase=/m/$USER/WSEC --email-from=autobuild-hrx0@samba.org --email=$USER@samba.org --branch="private" --always-email --tail --keeplogs --verbose --restrict-tests=POSIX on sn-sevel and it passed, so I'm at my whits end. Jeremy, the test if failing right at the beginning when creating the testfile with cli_posix_open(). Go figure... :(
OK, let me try and modify the to create the file using standard mechanisms instead. Shouldn't make any difference, but if it gets the test to pass I won't worry about it :-).
Created attachment 16743 [details] git-am fix for 4.14.next. Can you try this version ? If nukes the test files using any possible methods then uses a cli_openx() to create the file. It shouldn't make any difference of course, as the original code should have been perfectly fine. But if it allows autobuild to pass I'm not going to worry about it :-).
Comment on attachment 16743 [details] git-am fix for 4.14.next. Works here in local testing of course.
(In reply to Jeremy Allison from comment #14) Pushed to autobuild-v4-14-test. Thanks for investigating!
(In reply to Jeremy Allison from comment #14) Failing again with: UNEXPECTED(failure): samba3.smbtorture_s3.crypt.POSIX-SYMLINK-SETPATHINFO.smbtorture(nt4_dc_smb1) REASON: Exception: Exception: using seed 1629373298 host=10.53.57.55 share=posix_share user=kseeger myname=lclnt4dc2smb1 Running POSIX-SYMLINK-SETPATHINFO Starting POSIX-SYMLINK-SETPATHINFO test cli_openx of file_setpath_real failed (NT_STATUS_ACCESS_DENIED) TEST POSIX-SYMLINK-SETPATHINFO FAILED!
(In reply to Karolin Seeger from comment #16) Drat! I was kind of expecting this. :/ Jeremy, maybe we just remove the test from the backport? I really don't have any idea what could be causing this.
I'm sorry Karolin, I just don't know what is going on. I'll remove the test from the backport and resubmit.
Created attachment 16747 [details] git-am fix for 4.14.next. Fix only, test removed. Sorry for the trouble.
(In reply to Jeremy Allison from comment #19) Pushed to autobuild-v4-14-test. Thanks for investigating!
This bug was referenced in samba v4-14-test: a7d66e00fa811512b0b44288474271453b914f21
Pushed to v4-14-test. Closing out bug report. Thanks!
This bug was referenced in samba v4-14-stable (Release samba-4.14.8): a7d66e00fa811512b0b44288474271453b914f21