Have fix, need bugnumber. When we're returning the struct smb_filename **atname, we allocate the atname->base_name off the wrong talloc context. All smb_filename->base_names should be allocated off the parent smb_filename, but parent_smb_fname() doesn't do this. In the normal use-cases we pass in talloc_tos() for the mem_ctx parameter for parent_smb_fname(), and so mostly we don't notice the problem. When I started using shadow_copy2 games however, this caused *horrible* valgrind errors that took me a couple of days to track down :-(. Note I will fix this differently in master using the new SMB_VFS_PARENT_PATHNAME) patchset so the patches I have are for 4.14.next, 4.13.next only.
Ah, never mind. I'll fix in master first the usual way, and rebase my SMB_VFS_PARENT_PATHNAME() to cope with deleting the newly correct code, rather than the buggy code. That way I can feed through ci as normal..
This bug was referenced in samba master: c500d99e2f5aaec102bf952b7941a2596b3e35a1
Created attachment 16640 [details] git-am fix for 4.14.next, 4.13.next.
Comment on attachment 16640 [details] git-am fix for 4.14.next, 4.13.next. Cherry-picked from master.
Comment on attachment 16640 [details] git-am fix for 4.14.next, 4.13.next. We rather need this to prevent valgrind errors..
Reassigning to Karolin for inclusion in 4.13 and 4.14.
(In reply to Ralph Böhme from comment #6) Pushed to autobuild-v4-{14,13}-test.
This bug was referenced in samba v4-13-test: 0b75c2723687c3536831175541ae34525c8bb1ab
This bug was referenced in samba v4-14-test: 35d7a23d72054363ec659b1d89e2e6fbd850a7a3
This bug was referenced in samba v4-14-stable (Release samba-4.14.6): 35d7a23d72054363ec659b1d89e2e6fbd850a7a3
This bug was referenced in samba v4-13-stable (Release samba-4.13.10): 0b75c2723687c3536831175541ae34525c8bb1ab
Closing out bug report. Thanks!