Have patch, need bugid.
==3627798== Invalid read of size 1 ==3627798== at 0x483FF46: strlen (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==3627798== by 0x55DE412: strdup (strdup.c:41) ==3627798== by 0x4F4657E: smb_xstrdup (util.c:660) ==3627798== by 0x4C62C2E: vfs_ChDir (vfs.c:988) ==3627798== by 0x4C4A51C: process_symlink_open (open.c:656) ==3627798== by 0x4C4ADE7: non_widelink_open (open.c:862) ==3627798== by 0x4C4AFB7: fd_openat (open.c:918) ==3627798== by 0x4BBE895: openat_pathref_fsp (files.c:506) ==3627798== by 0x4C48A00: filename_convert_internal (filename.c:2027) ==3627798== by 0x4C48B77: filename_convert (filename.c:2067) ==3627798== by 0x4C32408: call_trans2qfilepathinfo (trans2.c:6173) ==3627798== by 0x4C3C5DA: handle_trans2 (trans2.c:10143) ==3627798== Address 0xda8bc90 is 96 bytes inside a block of size 217 free'd ==3627798== at 0x483DA3F: free (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==3627798== by 0x4FCA3C9: _tc_free_internal (talloc.c:1222) ==3627798== by 0x4FCA481: _talloc_free_internal (talloc.c:1248) ==3627798== by 0x4FCB825: _talloc_free (talloc.c:1792) ==3627798== by 0xDB248DD: store_cwd_data (vfs_shadow_copy2.c:1473) ==3627798== by 0xDB24BEF: shadow_copy2_chdir (vfs_shadow_copy2.c:1542) ==3627798== by 0x4C662A4: smb_vfs_call_chdir (vfs.c:2257) ==3627798== by 0x4C62B48: vfs_ChDir (vfs.c:940) ==3627798== by 0x4C4A51C: process_symlink_open (open.c:656) ==3627798== by 0x4C4ADE7: non_widelink_open (open.c:862) ==3627798== by 0x4C4AFB7: fd_openat (open.c:918) ==3627798== by 0x4BBE895: openat_pathref_fsp (files.c:506) ==3627798== Block was alloc'd at ==3627798== at 0x483C7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so) ==3627798== by 0x4FC9365: __talloc_with_prefix (talloc.c:783) ==3627798== by 0x4FC94FF: __talloc (talloc.c:825) ==3627798== by 0x4FCCFDC: __talloc_strlendup (talloc.c:2454) ==3627798== by 0x4FCD096: talloc_strdup (talloc.c:2470) ==3627798== by 0xDB24977: store_cwd_data (vfs_shadow_copy2.c:1476) ==3627798== by 0xDB24BEF: shadow_copy2_chdir (vfs_shadow_copy2.c:1542) ==3627798== by 0x4C662A4: smb_vfs_call_chdir (vfs.c:2257) ==3627798== by 0x4C62B48: vfs_ChDir (vfs.c:940) ==3627798== by 0x4C4A92D: non_widelink_open (open.c:755) ==3627798== by 0x4C4AFB7: fd_openat (open.c:918) ==3627798== by 0x4BBE895: openat_pathref_fsp (files.c:506) ==3627798==
Created attachment 16630 [details] git-am fix for master. In gitlab-ci right now. I'll post the MR for it once it passes.
Comment on attachment 16630 [details] git-am fix for master. Good catch, thanks!
MR: https://gitlab.com/samba-team/samba/-/merge_requests/1985 I'm pushing now.
This bug was referenced in samba master: 2f0cfe82907516ecf23cc385d41b8d29ed6b8c96
Created attachment 16632 [details] git-am fix for 4.14.next. Cherry-pick from master.
Created attachment 16633 [details] git-am fix for 4.13.next. Back-port from master, cherry pick failed.
Reassigning to Karolin for inclusion in 4.13 and 4.14.
(In reply to Ralph Böhme from comment #8) Pushed to autobuild-v4-{14,13}-test.
This bug was referenced in samba v4-14-test: e7e537d77ccfdaa526e5759ea770e034426a4f23
In v4-13-test, make fails with this patch.
This bug was referenced in samba v4-14-stable (Release samba-4.14.5): e7e537d77ccfdaa526e5759ea770e034426a4f23
Karolin can you let me know the specific test that fails with 4.13 ? Thanks ! Jeremy.
Created attachment 16661 [details] git-am fix for 4.13.next. Karolin, sorry for the error. Mixed up return variable types (4.13 requires, errno = ENOMEM, return -1 not return NT_STATUS_NO_MEMORY). This should now build.
This bug was referenced in samba v4-13-test: b01c4526fef64ac7458459111d0715434ca3f2a2
This bug was referenced in samba v4-13-stable (Release samba-4.13.10): b01c4526fef64ac7458459111d0715434ca3f2a2