Entries in registry.pol.xml can have empty value entries after backup. This leads to an exception during restore and subsequent failure of restoring a GPO.
<Entry type="7" type_name="REG_MULTI_SZ">
There is a check for empty REG_SZ and REG_EXPAND_SZ but not for REG_MULTI_SZ.
Created attachment 16589 [details]
This looks good to me - but is there a specific registry.pol.xml we can add a test empty value to in order to regression test the fix is good ?
Can we add one to:
for a test ?
Created attachment 16598 [details]
Added Registry.pol.xml for testing
(In reply to Jeremy Allison from comment #2)
I've updated the patch to include the GPO "Let Windows apps access the camera" which has multiple empty REG_MULTI_SZ values. Should I also update the binary Registry.pol.SAMBABACKUP file?
I think that covers the testing part, yes ? Once it's in that file I think the selftests will pack/unpack it - correct ? If that's so I think this patch is good to go.
Created attachment 16601 [details]
Patch passing test suite
(In reply to Jeremy Allison from comment #5)
Ran the test suite and the previous patch didn't pass. I've updated the patch so it passes the selftest (Registry.pol.SAMBABACKUP need updating too).