I am sorry I didn't catch this sooner. the _openat function breaks in a few key ways. The assert no longer works. In fixing this I believe I have also fixed an upcoming problem by changing to using the SMB_VFS_FSTAT_NEXT function instead of _STAT_NEXT.
I will push the patch shortly. It has been tested. I do worry if this is backportable to before 4.14.0. I also wonder if these changes will work as intended as I do not have a setup where the backing system does not have actual FDs which is what is needed for this module to work properly.
[2021/03/13 11:48:50.505469, 0] ../../source3/lib/dumpcore.c:317(dump_core)
coredump is handled by helper binary specified at /proc/sys/kernel/core_pattern
[2021/03/13 11:51:53.955497, 0] ../../source3/modules/vfs_virusfilter.c:1245(virusfilter_vfs_openat)
PANIC: assert failed at ../../source3/modules/vfs_virusfilter.c(1245): fsp_get_pathref_fd(dirfsp) == AT_FDCWD
[2021/03/13 11:51:53.957585, 0] ../../lib/util/fault.c:172(smb_panic_log)
Created attachment 16541 [details]
necessary VFS patch for vfs_virusfilter vs 4.14.0
This patch is currently working on my systems and has passed initial build in pipeline.
The merge request can be found at https://gitlab.com/samba-team/samba/-/merge_requests/1840
This bug was referenced in samba master:
Created attachment 16563 [details]
git-am fix for 4.14.next.
Cherry-pick from master.
Re-assigning to Karolin for inclusion in 4.14.next.
(In reply to Jeremy Allison from comment #5)
Pushed to autobuild-v4-14-test.
This bug was referenced in samba v4-14-test:
Closing out bug report.
This bug was referenced in samba v4-14-stable (Release samba-4.14.3):