Bug 14654 - dos attributes not available for unreadable files
Summary: dos attributes not available for unreadable files
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.13.3
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
: 2118 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-04 23:30 UTC by Björn Jacke
Modified: 2021-08-24 13:25 UTC (History)
3 users (show)

See Also:

Attachments
backport for 4.14 (1.61 KB, patch)
2021-03-25 09:37 UTC, Björn Jacke 		bjacke: review+
slow: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2021-03-04 23:30:21 UTC 
dos attributes are not available for unreadable files.
Have patch, need bug number.
Comment 1 Björn Jacke 2021-03-11 16:59:09 UTC 
I just saw that Ralph fixed the same problem (for gpfs only though) back in 2017 already, see bug 12944
Comment 2 Samba QA Contact 2021-03-24 21:29:11 UTC 
This bug was referenced in samba master:

4288319770bc1bde28b1e9ac4bb287e29853378d
Comment 3 Björn Jacke 2021-03-25 09:37:43 UTC 
Created attachment 16570 [details]
backport for 4.14
Comment 4 Björn Jacke 2021-04-06 18:36:22 UTC 
the backport is fo 4.14 only, not 4.13 as I wrote above.

looking at the issue in 4.13 confused me quite a but: 4.13 had this *almost* correct. After 4.13 the new code from d466ba6d61365f72618dd3093706b8706b8f7c93 that replaced the old  get_ea_dos_attribute code that was removed in 3db25c1c9b3f0d5ec91905b068a0da3daa581e02 had a errno == EACCES conditioned become_root.

To make the long story short, in 4.13 just the errno==EPERM condition was missing in get_ea_dos_attribute. I leave 4.13 alone though. master has it right now and 4.14 should get the backport.
Comment 5 Björn Jacke 2021-06-28 18:53:19 UTC 
*** Bug 2118 has been marked as a duplicate of this bug. ***
Comment 6 Ralph Böhme 2021-07-28 12:35:11 UTC 
Reassigning to Karolin for inclusion in 4.14.
Comment 7 Samba QA Contact 2021-08-11 10:56:03 UTC 
This bug was referenced in samba v4-14-test:

9c470eb6cd7f7782c81fe7bd39dd9b4c4e893747
Comment 8 Karolin Seeger 2021-08-12 11:09:04 UTC 
Pushed to v4-14-test.
Closing out bug report.

Thanks!
Comment 9 Samba QA Contact 2021-08-24 13:25:12 UTC 
This bug was referenced in samba v4-14-stable (Release samba-4.14.7):

9c470eb6cd7f7782c81fe7bd39dd9b4c4e893747