Bug 14644 - 4.14.0rc4 fails to compile due to error in vfs_zfsacl.c
Summary: 4.14.0rc4 fails to compile due to error in vfs_zfsacl.c
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.14.0rc4
Hardware: All FreeBSD
: P5 normal (vote)
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2021-02-18 12:07 UTC by Peter Eriksson
Modified: 2021-08-17 11:25 UTC (History)
2 users (show)

See Also:

Patch to fix vfs_zfsacl compilation problem (1.43 KB, patch)
2021-03-01 12:00 UTC, Peter Eriksson
no flags Details
git-am fix for 4.14.RCnext. (2.11 KB, patch)
2021-03-01 17:44 UTC, Jeremy Allison
slow: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Eriksson 2021-02-18 12:07:44 UTC
[3223/3763] Linking bin/default/source3/modules/libvfs_module_expand_msdfs.so
../../source3/modules/vfs_zfsacl.c: In function 'zfs_process_smbacl':
../../source3/modules/vfs_zfsacl.c:238:13: error: dereferencing pointer to incomplete type 'struct fd_handle'
  if (fsp->fh->fd != -1) {

Waf: Leaving directory `/export/software/Build/samba/samba-4.14.0rc3/bin/default'
Build failed
 -> task in 'vfs_zfsacl.objlist' failed with exit status 1 (run with -v to display more information)
gmake: *** [Makefile:7: all] Error 1
Comment 1 Peter Eriksson 2021-03-01 12:00:17 UTC
Created attachment 16476 [details]
Patch to fix vfs_zfsacl compilation problem

Still the same compilation problem in 4.14.0rc4. Attached is a patch that fixes the compilation problem.
Comment 2 Jeremy Allison 2021-03-01 17:44:32 UTC
Created attachment 16480 [details]
git-am fix for 4.14.RCnext.

Cherry-pick from what went into master.
Comment 3 Jeremy Allison 2021-03-01 17:45:03 UTC
Thanks Peter, this already got fixed in master. Just needs a second Team reviewer to add to 4.14.rcNExt.
Comment 4 Ralph Böhme 2021-07-28 12:31:42 UTC
Reassigning to Karolin for inclusion in 4.14 (only).
Comment 5 Karolin Seeger 2021-08-12 11:18:28 UTC
(In reply to Ralph Böhme from comment #4)
Pushed to autobuild-v4-14-test.
Comment 6 Karolin Seeger 2021-08-17 11:25:48 UTC
(In reply to Karolin Seeger from comment #5)
Pushed to v4-14-test.
Closing out bug report.