I will be attaching a patch for this. lp_parm_const_string returns NULL if the parameter isn't present. talloc recently changed to not allocate an empty string for NULL provided strings.
This caused the current checks for out of memory type situations to incorrectly trigger. The patch provided fixes this.
Created attachment 16435 [details]
Patch which fixes the problem. Working through CI on gitlab.com right now.
I believe I am following the new procedure correctly. https://gitlab.com/treveradams/samba.git is my branch with the fix pushed.
Created attachment 16475 [details]
git-am fix for master.
Trever, I think this version is clearer to read. If you're happy, can you re-push to your CI and I'll get second Team review done for this.
FYI, once applied it's easier to see the changes doing:
git show -b
(In reply to Jeremy Allison from comment #3)
Thank you. I agree. This version you have made is much better. It has been pushed.
This bug was referenced in samba master:
Created attachment 16482 [details]
git-am fix for 4.14.rcNext, 4.13.next, 4.12.next.
Cherry-picked from master.
Re-assigning to Karolin for inclusion in 4.14.next, 4.13.next, 4.12.next.