Bug 14575 - Failure to restore a backup due to duplicate SID gives traceback
Summary: Failure to restore a backup due to duplicate SID gives traceback
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: AD: LDB/DSDB/SAMDB (show other bugs)
Version: 4.13.1
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-13 02:24 UTC by Andrew Bartlett
Modified: 2021-07-14 08:16 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Bartlett 2020-11-13 02:24:47 UTC 
It shouldn't happen that a SID can be allocatable from the pool of a DC (even manually as happens in the 'samba-tool domain backup online' command) and be a duplicate, but such things can happen if RID master roles are stolen around.

This currently gives a traceback with warnings from the unique index code in LDB.
Comment 1 Samba QA Contact 2020-11-26 08:17:08 UTC 
This bug was referenced in samba master:

15609cb91986b3e29c5b1a3b6c69c04829f43eb4
Comment 2 Samba QA Contact 2020-11-26 21:16:04 UTC 
This bug was referenced in samba master:

8ad82ae66157c893a2b84d353ec4d9feb4815ede
Comment 3 Samba QA Contact 2021-07-13 13:19:21 UTC 
This bug was referenced in samba v4-13-test:

6e284db78779aae20b49300ae304c5b643f31b7d
d0bde5703b25fb34a0b672422c052909b1acbbef
Comment 4 Samba QA Contact 2021-07-14 08:16:45 UTC 
This bug was referenced in samba v4-13-stable (Release samba-4.13.10):

6e284db78779aae20b49300ae304c5b643f31b7d
d0bde5703b25fb34a0b672422c052909b1acbbef