Bug 14543 - find_service() prefers home directories over explicit services when registry shares are used
Summary: find_service() prefers home directories over explicit services when registry ...
Status: ASSIGNED
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: File services (show other bugs)
Version: 4.12.7
Hardware: All All
: P5 normal (vote)
Target Milestone: ---
Assignee: Jeremy Allison
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-21 09:50 UTC by Andrew Walker
Modified: 2021-03-15 01:58 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Walker 2020-10-21 09:50:22 UTC 
Registry shares are currently loaded in find_service() after the check for whether the service is a home directory. This is a problem because if a user has a [media] service and a user "media" with a homedir of /var/empty, then attempts to access \\server\media will land in /var/empty rather that [media].

Have fix in gitlab and will add reference to MR once I get the bug number for it.
Comment 2 Jeremy Allison 2020-10-21 17:17:14 UTC 
Yep. Completely correct. LGTM. Waiting for second Team reviewer.
Comment 3 Samba QA Contact 2020-10-22 00:31:06 UTC 
This bug was referenced in samba master:

7b52c2db264a92ea77bcb7e45e016ea03f699393
Comment 4 Andrew Bartlett 2021-03-08 06:22:20 UTC 
This bug is marked as 'team and vendors only', should it be opened as the patch landed publicly?
Comment 5 Andrew Bartlett 2021-03-15 01:58:25 UTC 
Removing embargo, given a public MR there isn't anything here worth keeping secret.