Registry shares are currently loaded in find_service() after the check for whether the service is a home directory. This is a problem because if a user has a [media] service and a user "media" with a homedir of /var/empty, then attempts to access \\server\media will land in /var/empty rather that [media].
Have fix in gitlab and will add reference to MR once I get the bug number for it.
Yep. Completely correct. LGTM. Waiting for second Team reviewer.
This bug was referenced in samba master:
This bug is marked as 'team and vendors only', should it be opened as the patch landed publicly?
Removing embargo, given a public MR there isn't anything here worth keeping secret.